On Thu, Jun 14, 2012 at 4:41 AM, Marco Nenciarini <
> following Gabriele's email regarding our previous patch on "Foreign
> Key Arrays", I am sending a subset of that patch which includes only
> two array functions which will be needed in that patch: array_remove
> (limited to single-dimensional arrays) and array_replace.
> The patch includes changes to the documentation.
Hi, I've been reviewing this patch.
Good documentation, and regression tests. The code looked fine but I didn't
care for the code duplication between array_replace and array_remove so I
merged those into a helper function, array_replace_internal(). Thoughts?
Other than that it all looks good to me.
In response to
pgsql-hackers by date
|Next:||From: Amit kapila||Date: 2012-06-30 07:11:15|
|Subject: patch-3 (3-allow-wal-record-header-to-be-split.patch)WAL Format
|Previous:||From: Peter Geoghegan||Date: 2012-06-30 01:28:13|
|Subject: Re: elog/ereport noreturn decoration|