Re: Proposal: knowing detail of config files via SQL

From: Sawada Masahiko <sawada(dot)mshk(at)gmail(dot)com>
To: David Steele <david(at)pgmasters(dot)net>
Cc: Robert Haas <robertmhaas(at)gmail(dot)com>, Stephen Frost <sfrost(at)snowman(dot)net>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, David Johnston <david(dot)g(dot)johnston(at)gmail(dot)com>, David Fetter <david(at)fetter(dot)org>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Proposal: knowing detail of config files via SQL
Date: 2015-04-30 03:54:49
Message-ID: CAD21AoDFcGZRufDFwR4PfHdFoGyUz+t9SE-5yiOGc3KKk2N+jg@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Thu, Apr 30, 2015 at 6:31 AM, David Steele <david(at)pgmasters(dot)net> wrote:
> On 4/29/15 5:16 PM, Robert Haas wrote:
>> On Fri, Apr 24, 2015 at 2:40 PM, David Steele <david(at)pgmasters(dot)net> wrote:
>>> <para>
>>> The view <structname>pg_file_settings</structname> provides access to
>>> run-time parameters
>>> that are defined in configuration files via SQL. In contrast to
>>> <structname>pg_settings</structname> a row is provided for each
>>> occurrence
>>> of the parameter in a configuration file. This is helpful for
>>> discovering why one value
>>> may have been used in preference to another when the parameters were
>>> loaded.
>>> </para>
>>
>> This seems to imply that this gives information about only a subset of
>> configuration files; specifically, those auto-generated based on SQL
>> commands - i.e. postgresql.conf.auto. But I think it's supposed to
>> give information about all configuration files, regardless of how
>> generated. Am I wrong? If not, I'd suggest "run-time parameters that
>> are defined in configuration files via SQL" -> "run-time parameters
>> stored in configuration files".
>
> The view does give information about all configuration files regardless
> of how they were created.
>
> That's what I intended the text to say but I think your phrasing is clearer.
>

Thank you for reviewing.
I agree with this.
Attached patch is updated version v10.

Regards,

-------
Sawada Masahiko

Attachment Content-Type Size
000_pg_file_settings_view_v10.patch text/x-diff 11.7 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Sawada Masahiko 2015-04-30 03:57:19 Re: Auditing extension for PostgreSQL (Take 2)
Previous Message Noah Misch 2015-04-30 03:17:22 Re: Make more portable TAP tests of initdb