Skip site navigation (1) Skip section navigation (2)

Re: port _srv.o makefile rules don't observe dependency tracking

From: Magnus Hagander <magnus(at)hagander(dot)net>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Alvaro Herrera <alvherre(at)commandprompt(dot)com>, Peter Eisentraut <peter_e(at)gmx(dot)net>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: port _srv.o makefile rules don't observe dependency tracking
Date: 2012-05-01 20:45:51
Message-ID: CABUevEyZ00MCRUSPNn9Yw7TRxos3sy62oDP3Eg++VOwm4SdADQ@mail.gmail.com (view raw or flat)
Thread:
Lists: pgsql-hackers
On Tue, May 1, 2012 at 10:25 PM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> Alvaro Herrera <alvherre(at)commandprompt(dot)com> writes:
>> Excerpts from Peter Eisentraut's message of mar may 01 15:30:25 -0400 2012:
>>> Instead, I thought this could easily be fixed by writing this:
>>>
>>> %_srv.o: %.c %.o
>>>      $(CC) $(CFLAGS) $(subst -DFRONTEND,, $(CPPFLAGS)) -c $< -o $@
>>>
>>> A bit hacky, but should get quite robust results.
>
>> So basically to build the _srv.o file you first need to build the .o?
>> Since both files need to be built anyway, I don't think this is a
>> problem.
>
> Are there, or might there be in the future, any "port" files that only
> exist in server flavor and not client-side flavor?  It doesn't seem
> terribly unlikely to me.  This is a cute hack but it assumes that
> everything in that directory can and should be built both ways.

Isn't that what backend/port/* is for?

-- 
 Magnus Hagander
 Me: http://www.hagander.net/
 Work: http://www.redpill-linpro.com/

In response to

Responses

pgsql-hackers by date

Next:From: Hannu KrosingDate: 2012-05-01 20:54:56
Subject: Re: JSON in 9.2 - Could we have just one to_json() function instead of two separate versions ?
Previous:From: Tom LaneDate: 2012-05-01 20:43:23
Subject: Re: port _srv.o makefile rules don't observe dependency tracking

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group