I've been a reader of this list for some time, but have never posted.
I have interest in the URI connection string support patch, so I'm in
the process of reviewing it. I have a couple of comments and questions:
1. I see no tests in the patch. I'd like to start getting together a set of
tests, likely based on the connection string permutations found on Greg
Smith's response. However I don't find an obvious place to put them.
They could possibly live in the test/examples directory. Another thought is
to use dblink in a test, although it may be problematic to depend on a
contrib package for a test, to say the least. Any thoughts on how to test
this are most welcome.
2. The documentation/manual was not updated as part of this patch, so this
3. I for one do prefer the `postgres` prefix, as opposed to `postgresql`
for the reasons stated on an earlier thread . In my opinion the best way
to move forward is to support them both.
The good news is the patch still applies fine on the 9.2 HEAD, and seems to
pgsql-hackers by date
|Next:||From: David E. Wheeler||Date: 2012-02-24 01:35:09|
|Subject: row_to_json() Bug|
|Previous:||From: Tom Lane||Date: 2012-02-24 00:15:18|
|Subject: Re: psql \i tab completion initialization problem on HEAD |