On Thu, Dec 6, 2012 at 12:29 AM, Phil Sorber <phil(at)omniti(dot)com> wrote:
> On Wed, Dec 5, 2012 at 8:53 AM, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>
> > No, I think it is the reference docs on the returned value that must be
> > fixed. That is, instead of saying that the return value correspond to
> > the enum values, you should be saying that it will return
> > <literal>0</literal> if it's okay, 1 in another case and 2 in yet
> > another case. And then next to the PQping() enum, add a comment that
> > the values must not be messed around with because pg_isready exposes
> > them to users and shell scripts.
> +1 I'm on board with this.
OK. Let's do that and then mark this patch as ready for committer.
In response to
pgsql-hackers by date
|Next:||From: Tom Lane||Date: 2012-12-07 02:10:21|
|Subject: Re: pg_upgrade problem with invalid indexes|
|Previous:||From: Stephen Frost||Date: 2012-12-07 01:49:22|
|Subject: Re: Commits 8de72b and 5457a1 (COPY FREEZE)|