| From: | Michael Paquier <michael(dot)paquier(at)gmail(dot)com> |
|---|---|
| To: | Phil Sorber <phil(at)omniti(dot)com> |
| Cc: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Dimitri Fontaine <dimitri(at)2ndquadrant(dot)fr>, Peter Eisentraut <peter_e(at)gmx(dot)net>, Bruce Momjian <bruce(at)momjian(dot)us>, PostgreSQL-development Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: [WIP] pg_ping utility |
| Date: | 2012-12-07 01:54:52 |
| Message-ID: | CAB7nPqSq+sebMNXGD+xBXUvbwrbmv-7mKqSdFgwpH9JuWuaV2Q@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Thu, Dec 6, 2012 at 12:29 AM, Phil Sorber <phil(at)omniti(dot)com> wrote:
> On Wed, Dec 5, 2012 at 8:53 AM, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>
> wrote:
> > No, I think it is the reference docs on the returned value that must be
> > fixed. That is, instead of saying that the return value correspond to
> > the enum values, you should be saying that it will return
> > <literal>0</literal> if it's okay, 1 in another case and 2 in yet
> > another case. And then next to the PQping() enum, add a comment that
> > the values must not be messed around with because pg_isready exposes
> > them to users and shell scripts.
>
> +1 I'm on board with this.
>
OK. Let's do that and then mark this patch as ready for committer.
Thanks,
--
Michael Paquier
http://michael.otacoo.com
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2012-12-07 02:10:21 | Re: pg_upgrade problem with invalid indexes |
| Previous Message | Stephen Frost | 2012-12-07 01:49:22 | Re: Commits 8de72b and 5457a1 (COPY FREEZE) |