Re: Bug in pg_dump

From: Michael Paquier <michael(dot)paquier(at)gmail(dot)com>
To: Gilles Darold <gilles(dot)darold(at)dalibo(dot)com>
Cc: Robert Haas <robertmhaas(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Bug in pg_dump
Date: 2015-02-26 11:41:46
Message-ID: CAB7nPqSSGmFhH9DrM-S49AQPV8h0agEi2JgPgKTzY8aZ6zBcYA@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Wed, Feb 25, 2015 at 7:46 AM, Gilles Darold <gilles(dot)darold(at)dalibo(dot)com> wrote:
> This is a far better patch and the test to export/import of the
> postgis_topology extension works great for me.
>
> Thanks for the work.

Attached is a patch that uses an even better approach by querying only
once all the FK dependencies of tables in extensions whose data is
registered as dumpable by getExtensionMembership(). Could you check
that it works correctly? My test case passes but an extra check would
be a good nice. The patch footprint is pretty low so we may be able to
backport this patch easily.
--
Michael

Attachment Content-Type Size
0001-Fix-ordering-of-tables-part-of-extensions-linked-wit.patch text/x-diff 3.9 KB
0002-Make-prove_check-install-contents-of-current-directo.patch text/x-diff 1.1 KB
0003-Add-dump_test-test-module-to-check-pg_dump-with-exte.patch text/x-diff 5.1 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Michael Paquier 2015-02-26 12:07:28 Re: How to create virtual indexes on postgres
Previous Message Andres Freund 2015-02-26 11:12:35 Re: [HACKERS] BDR Multiple database