Re: pgsql: Add putenv support for msvcrt from Visual Studio 2013

From: Michael Paquier <michael(dot)paquier(at)gmail(dot)com>
To: Noah Misch <noah(at)leadboat(dot)com>
Cc: Christian Ullrich <chris(at)chrullrich(dot)net>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>, Andrew Dunstan <andrew(at)dunslane(dot)net>, Magnus Hagander <magnus(at)hagander(dot)net>
Subject: Re: pgsql: Add putenv support for msvcrt from Visual Studio 2013
Date: 2016-12-05 01:24:56
Message-ID: CAB7nPqSRfAYLeHso-g1RtF50jKcTuN-vESHxLbdvp2w0bxgsCg@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers

On Sun, Dec 4, 2016 at 5:58 AM, Noah Misch <noah(at)leadboat(dot)com> wrote:
> On Wed, Nov 30, 2016 at 04:24:34PM +0000, Christian Ullrich wrote:
>> * From: Michael Paquier
>> > would be nice to mention in a code comment that this what Noah has
>> > mentioned upthread: if a CRT loads while pgwin32_putenv() is
>> > executing, the newly-loaded CRT will always have the latest value.
>>
>> I fixed the existing comment by removing the last sentence that is in the wrong place now, but I don't see the point in suddenly starting to explain why it is done this way and not the other.
>>
>> > Based on that 0006 will need a rebase, nothing huge though.
>>
>> Done, new revisions attached.
>
> I committed patches 1-7 with some comment changes, a pgindent, and other
> cosmetic trivia. (The file was pgindent-clean before this work. Patch 6
> still achieved the more-compact formatting you sought.)

Thanks all for helping in closing this item. We have a fine result here.
--
Michael

In response to

Browse pgsql-committers by date

  From Date Subject
Next Message Fujii Masao 2016-12-05 11:32:20 pgsql: Fix incorrect output from gin_desc().
Previous Message Tom Lane 2016-12-04 20:03:06 pgsql: Don't mess up pstate->p_next_resno in transformOnConflictClause(

Browse pgsql-hackers by date

  From Date Subject
Next Message Amit Kapila 2016-12-05 02:14:05 Re: Speed up Clog Access by increasing CLOG buffers
Previous Message Ian Barwick 2016-12-05 00:55:19 Re: monitoring.sgml - clarify length of query text displayed in pg_stat_statements