Re: TABLESAMPLE patch

From: Michael Paquier <michael(dot)paquier(at)gmail(dot)com>
To: Petr Jelinek <petr(at)2ndquadrant(dot)com>
Cc: Peter Eisentraut <peter_e(at)gmx(dot)net>, Jeff Janes <jeff(dot)janes(at)gmail(dot)com>, Simon Riggs <simon(at)2ndquadrant(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, Tomas Vondra <tomas(dot)vondra(at)2ndquadrant(dot)com>, Jaime Casanova <jaime(at)2ndquadrant(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>, Tomas Vondra <tv(at)fuzzy(dot)cz>
Subject: Re: TABLESAMPLE patch
Date: 2015-04-23 00:36:54
Message-ID: CAB7nPqQRaZ3jBwhc7QCDQMN1ppfHqYVVQABup6eQf2dKZS2=zQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Thu, Apr 23, 2015 at 4:31 AM, Petr Jelinek <petr(at)2ndquadrant(dot)com> wrote:
> On 19/04/15 01:24, Michael Paquier wrote:
>>
>> On Sat, Apr 18, 2015 at 8:38 PM, Michael Paquier
>> <michael(dot)paquier(at)gmail(dot)com> wrote:
>>>
>>> On Fri, Apr 17, 2015 at 10:54 PM, Petr Jelinek wrote:
>>>>
>>>> On 10/04/15 06:46, Michael Paquier wrote:
>>>>>
>>>>> 13) Some regression tests with pg_tablesample_method would be welcome.
>>>>
>>>>
>>>> Not sure what you mean by that.
>>>
>>>
>>> I meant a sanity check on pg_tablesample_method to be sure that
>>> tsminit, tsmnextblock and tsmnexttuple are always defined as they are
>>> mandatory functions. So the idea is to add a query like and and to be
>>> sure that it returns no rows:
>>> SELECT tsmname FROM pg_tablesample_method WHERE tsminit IS NOT NULL OR
>>> tsmnextblock IS NOT NULL OR tsmnexttuple IS NOT NULL;
>>
>>
>> Yesterday was a long day. I meant IS NULL and not IS NOT NULL, but I
>> am sure you guessed it that way already..
>>
>
> Yes I guessed that and it's very reasonable request, I guess it should look
> like the attached (I don't want to send new version of everything just for
> this).

Thanks. That's exactly the idea.
--
Michael

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Bruce Momjian 2015-04-23 00:55:40 Re: Freeze avoidance of very large table.
Previous Message Kyotaro HORIGUCHI 2015-04-23 00:10:02 Re: inherit support for foreign tables