From:
Daniel Farina <daniel(at)heroku(dot)com>
To:
Peter Geoghegan <peter(at)2ndquadrant(dot)com>
Cc:
Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Robert Haas <robertmhaas(at)gmail(dot)com>, PG Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject:
Re: Re: pg_stat_statements normalisation without invasive
changes to the parser (was: Next steps on pg_stat_statements normalisation)
Date:
2012-02-29 09:05:01
Message-ID:
CAAZKuFZFousg18xmmLWR1E+3Z3xc2K+BUxyVei+cdix9v4zz2g@mail.gmail.com (view raw or flat )
Thread:
2012-02-16 21:11:56 from Peter Geoghegan <peter(at)2ndquadrant(dot)com>
2012-02-20 23:16:04 from Peter Geoghegan <peter(at)2ndquadrant(dot)com>
2012-02-21 01:19:55 from Peter Geoghegan <peter(at)2ndquadrant(dot)com>
2012-02-21 01:50:58 from Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
2012-02-21 01:48:30 from Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
2012-02-21 10:03:27 from Peter Geoghegan <peter(at)2ndquadrant(dot)com>
2012-02-24 14:43:14 from Peter Geoghegan <peter(at)2ndquadrant(dot)com>
2012-02-27 04:59:11 from Robert Haas <robertmhaas(at)gmail(dot)com>
2012-02-27 06:23:48 from Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
2012-02-27 12:26:33 from Peter Geoghegan <peter(at)2ndquadrant(dot)com>
2012-02-29 09:05:01 from Daniel Farina <daniel(at)heroku(dot)com>
2012-02-29 23:40:05 from Peter Geoghegan <peter(at)2ndquadrant(dot)com>
2012-03-01 00:48:27 from Alvaro Herrera <alvherre(at)commandprompt(dot)com>
2012-03-01 21:27:25 from Peter Geoghegan <peter(at)2ndquadrant(dot)com>
2012-03-01 21:57:36 from Daniel Farina <daniel(at)heroku(dot)com>
2012-03-01 22:09:34 from Josh Berkus <josh(at)agliodbs(dot)com>
2012-03-02 02:13:29 from Peter Geoghegan <peter(at)2ndquadrant(dot)com>
2012-03-02 17:35:23 from Josh Berkus <josh(at)agliodbs(dot)com>
2012-03-02 17:48:30 from Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
2012-03-02 19:36:28 from Robert Haas <robertmhaas(at)gmail(dot)com>
2012-03-02 20:10:23 from Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
2012-03-13 19:02:18 from Peter Geoghegan <peter(at)2ndquadrant(dot)com>
2012-03-13 19:52:45 from Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
2012-03-17 22:47:45 from Peter Geoghegan <peter(at)2ndquadrant(dot)com>
2012-03-18 16:13:23 from Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
2012-03-18 22:12:14 from Peter Geoghegan <peter(at)2ndquadrant(dot)com>
2012-03-18 22:46:41 from Andrew Dunstan <andrew(at)dunslane(dot)net>
2012-03-18 23:46:41 from Peter Geoghegan <peter(at)2ndquadrant(dot)com>
2012-03-19 00:10:44 from Andrew Dunstan <andrew(at)dunslane(dot)net>
2012-03-19 00:55:16 from Peter Geoghegan <peter(at)2ndquadrant(dot)com>
2012-03-19 01:50:34 from Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
2012-03-19 02:35:44 from Peter Geoghegan <peter(at)2ndquadrant(dot)com>
2012-03-19 19:49:32 from Peter Eisentraut <peter_e(at)gmx(dot)net>
2012-03-20 04:29:49 from Noah Misch <noah(at)leadboat(dot)com>
2012-03-19 21:53:22 from Daniel Farina <daniel(at)heroku(dot)com>
2012-03-19 08:59:11 from Greg Stark <stark(at)mit(dot)edu>
2012-03-19 19:55:55 from Peter Eisentraut <peter_e(at)gmx(dot)net>
2012-03-19 20:48:07 from Peter Geoghegan <peter(at)2ndquadrant(dot)com>
2012-03-20 17:21:57 from Bruce Momjian <bruce(at)momjian(dot)us>
2012-03-02 19:47:49 from Simon Riggs <simon(at)2ndQuadrant(dot)com>
2012-03-02 19:56:45 from Josh Berkus <josh(at)agliodbs(dot)com>
2012-03-02 20:13:02 from Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
2012-03-02 21:56:45 from Simon Riggs <simon(at)2ndQuadrant(dot)com>
2012-03-03 00:01:24 from Robert Haas <robertmhaas(at)gmail(dot)com>
2012-03-05 10:12:24 from Simon Riggs <simon(at)2ndQuadrant(dot)com>
2012-03-05 13:24:28 from Andrew Dunstan <andrew(at)dunslane(dot)net>
2012-03-22 17:19:04 from Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
2012-03-22 18:49:33 from Peter Geoghegan <peter(at)2ndquadrant(dot)com>
2012-03-22 19:07:55 from Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
2012-03-22 19:11:48 from Peter Geoghegan <peter(at)2ndquadrant(dot)com>
2012-03-25 14:34:29 from Peter Geoghegan <peter(at)2ndquadrant(dot)com>
2012-03-27 17:15:50 from Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
2012-03-27 18:47:06 from Peter Geoghegan <peter(at)2ndquadrant(dot)com>
2012-03-27 21:05:30 from Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
2012-03-28 09:47:49 from Peter Geoghegan <peter(at)2ndquadrant(dot)com>
2012-03-27 19:26:55 from Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
2012-03-27 19:47:38 from Peter Geoghegan <peter(at)2ndquadrant(dot)com>
2012-03-28 14:12:31 from Peter Geoghegan <peter(at)2ndquadrant(dot)com>
2012-03-28 14:25:26 from Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
2012-03-28 14:45:25 from Peter Geoghegan <peter(at)2ndquadrant(dot)com>
2012-03-28 15:06:01 from Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
2012-03-28 14:57:51 from Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
2012-03-28 16:44:58 from Peter Geoghegan <peter(at)2ndquadrant(dot)com>
2012-03-28 23:14:43 from Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
2012-03-28 23:52:23 from Peter Geoghegan <peter(at)2ndquadrant(dot)com>
2012-03-29 01:09:41 from Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
2012-03-29 02:39:33 from Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
2012-03-29 10:38:40 from Robert Haas <robertmhaas(at)gmail(dot)com>
2012-03-29 15:23:40 from Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
2012-03-29 15:34:54 from Robert Haas <robertmhaas(at)gmail(dot)com>
2012-03-29 15:42:10 from Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
2012-03-29 16:07:19 from Robert Haas <robertmhaas(at)gmail(dot)com>
2012-03-29 16:12:10 from Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
2012-03-29 16:31:14 from Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
2012-03-29 17:57:19 from Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
2012-03-29 20:05:59 from Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
2012-03-29 20:08:04 from Robert Haas <robertmhaas(at)gmail(dot)com>
2012-04-06 14:32:49 from Peter Geoghegan <peter(at)2ndquadrant(dot)com>
2012-04-08 19:51:02 from Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
2012-04-08 23:00:34 from Peter Geoghegan <peter(at)2ndquadrant(dot)com>
2012-04-09 15:18:43 from Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
2012-03-29 11:13:57 from Peter Geoghegan <peter(at)2ndquadrant(dot)com>
Lists:
pgsql-hackers
On Mon, Feb 27, 2012 at 4:26 AM, Peter Geoghegan <peter(at)2ndquadrant(dot)com> wrote:
> This does not appear to have any user-visible effect on caret position
> for all variations in coercion syntax, while giving me everything that
> I need. I had assumed that we were relying on things being this way,
> but apparently this is not the case. The system is correctly blaming
> the coercion token when it finds the coercion is at fault, and the
> const token when it finds the Const node at fault, just as it did
> before. So this looks like a case of removing what amounts to dead
> code.
To shed some light on that hypothesis, attached is a patch whereby I
use 'semantic analysis by compiler error' to show the extent of the
reach of the changes by renaming (codebase-wide) the Const node's
location symbol. The scope whereby the error token will change
position is small and amenable to analysis. I don't see a problem,
nor wide-reaching consequences. As Peter says: probably dead code.
Note that the cancellation of the error position happens very soon,
after an invocation of stringTypeDatum (on two sides of a branch).
Pre and post-patch is puts the carat at the beginning of the constant
string, even in event there is a failure to parse it properly to the
destined type.
--
fdr
In response to
Responses
pgsql-hackers by date
Next :From: Andrea SuisaniDate: 2012-02-29 09:22:05Subject : Re: swapcache-style cache?Previous :From : Simon RiggsDate : 2012-02-29 08:18:05Subject : Re: Parameterized-path cost comparisons need some work
