Skip site navigation (1) Skip section navigation (2)

Re: pg_stat_statements normalization: re-review

From: Daniel Farina <daniel(at)heroku(dot)com>
To: Peter Geoghegan <peter(at)2ndquadrant(dot)com>
Cc: pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: pg_stat_statements normalization: re-review
Date: 2012-02-24 12:36:39
Message-ID: CAAZKuFYHe9N1RHNnLRv4prVmKCh9pSP6mT+umnY5bwHGWTrSRQ@mail.gmail.com (view raw or flat)
Thread:
Lists: pgsql-hackers
On Fri, Feb 24, 2012 at 3:14 AM, Daniel Farina <daniel(at)heroku(dot)com> wrote:
> At ExecutorFinish (already hookable) all NodeKeys remembered by an
> extension should be invalidated, as that memory is free and ready to
> be used again.

I think this statement is false; I thought it was true because *not*
invalidating gives me correct-appearing but unsound results.

Firstly, it should be ExecutorEnd, not ExecutorFinish, but this
doesn't work because those run in the exec_simple_query path twice:
once in the planner and then again in PortalCleanup, it's important
that invalidation only occur at the end, and not twice.  So there's a
problem of a kind resulting from this experiment.

-- 
fdr

In response to

pgsql-hackers by date

Next:From: Peter EisentrautDate: 2012-02-24 12:45:25
Subject: Re: ISO8601 nitpicking
Previous:From: Marko KreenDate: 2012-02-24 12:11:45
Subject: Re: Speed dblink using alternate libpq tuple storage

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group