Skip site navigation (1) Skip section navigation (2)

Re: Prevent duplicate attributes

From: Thom Brown <thom(at)linux(dot)com>
To: Guillaume Lelarge <guillaume(at)lelarge(dot)info>
Cc: Dave Page <dpage(at)pgadmin(dot)org>, pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>
Subject: Re: Prevent duplicate attributes
Date: 2011-07-18 21:35:07
Message-ID: CAA-aLv5Tjm5JeRNWRhd2EfwEB5MWea+mj2QbTu1i28yioMug_Q@mail.gmail.com (view raw or flat)
Thread:
Lists: pgadmin-hackers
On 18 July 2011 22:25, Guillaume Lelarge <guillaume(at)lelarge(dot)info> wrote:
> On Mon, 2011-07-18 at 22:15 +0100, Thom Brown wrote:
>> On 18 July 2011 21:55, Guillaume Lelarge <guillaume(at)lelarge(dot)info> wrote:
>> > On Mon, 2011-07-18 at 21:06 +0100, Thom Brown wrote:
>> >> On 14 July 2011 10:31, Thom Brown <thom(at)linux(dot)com> wrote:
>> >> > On 14 July 2011 10:24, Guillaume Lelarge <guillaume(at)lelarge(dot)info> wrote:
>> >> >> So, you're working on fixing it, right?
>> >> >
>> >> > Possibly ;)  : http://code.pgadmin.org/trac/ticket/329
>> >> >
>> >> > I haven't had time to look at fixing various bugs over the last couple
>> >> > days but I'll get to them shortly.
>> >>
>> >> Apologies for the delay but I've now had a moment to look at it.
>> >
>> > No apologies needed :)
>> >
>> >>   The
>> >> attached patch removes the duplicate restriction from OnMemberAdd to
>> >> OnChangeMember, and also disabled the Add button by default.  This is
>> >> because it's enabled on loading the form which doesn't get disabled
>> >> again until you start editing the attribute name field, meaning you
>> >> can click Add without having provided any attribute details.
>> >>
>> >
>> > I'm wondering why you didn't take care of the Change button too. I mean,
>> > it's so easy now that you've the code working for the Add button that I
>> > kind of feel I'm missing something obvious which would explain why you
>> > didn't do it. Any particular reason other than "I forgot it"? :)
>>
>> Wasn't even that.  It didn't cross my mind.  Reattached with that change.
>>
>
> Thanks, commited. Only on master. Not sure it really qualifies as a bug.

Cheers. :)

-- 
Thom Brown
Twitter: @darkixion
IRC (freenode): dark_ixion
Registered Linux user: #516935

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

In response to

pgadmin-hackers by date

Next:From: pgAdmin TracDate: 2011-07-18 21:44:13
Subject: Re: [pgAdmin III] #328: Column collation change has no effect
Previous:From: Guillaume LelargeDate: 2011-07-18 21:25:46
Subject: Re: Prevent duplicate attributes

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group