Skip site navigation (1) Skip section navigation (2)

Re: clog double-dip in heap_hot_search_buffer

From: Simon Riggs <simon(at)2ndQuadrant(dot)com>
To: Robert Haas <robertmhaas(at)gmail(dot)com>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: clog double-dip in heap_hot_search_buffer
Date: 2012-05-02 16:16:45
Message-ID: CA+U5nMLZtVSOCZpDqdsArnXObZ=msABnEw6j=OykL71dc_BAyA@mail.gmail.com (view raw or flat)
Thread:
Lists: pgsql-hackers
On Wed, May 2, 2012 at 5:07 PM, Robert Haas <robertmhaas(at)gmail(dot)com> wrote:
> On Wed, May 2, 2012 at 12:06 PM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>> Robert Haas <robertmhaas(at)gmail(dot)com> writes:
>>> +     /* Deleter committed, so tuple is alive if the XID is old enough. */
>>> +     return TransactionIdPrecedes(HeapTupleHeaderGetXmax(tuple), OldestXmin);
>>
>> s/alive/dead/ in that comment?
>
> Yep, good catch, thanks.
>
>> Otherwise this seems like a good idea.
>
> Do you think I should apply this to 9.2, or wait until 9.3?

Now please. Well done.

-- 
 Simon Riggs                   http://www.2ndQuadrant.com/
 PostgreSQL Development, 24x7 Support, Training & Services

In response to

pgsql-hackers by date

Next:From: Tom LaneDate: 2012-05-02 16:19:04
Subject: Re: clog double-dip in heap_hot_search_buffer
Previous:From: Simon RiggsDate: 2012-05-02 16:15:38
Subject: Re: Temporary tables under hot standby

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group