Skip site navigation (1) Skip section navigation (2)

Re: [COMMITTERS] pgsql: Enable CHECK constraints to be declared NOT VALID

From: Simon Riggs <simon(at)2ndQuadrant(dot)com>
To: Peter Eisentraut <peter_e(at)gmx(dot)net>
Cc: Alvaro Herrera <alvherre(at)commandprompt(dot)com>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [COMMITTERS] pgsql: Enable CHECK constraints to be declared NOT VALID
Date: 2011-07-03 20:07:40
Message-ID: CA+U5nMKObOHoc5BEx5OgRqr53VmfQhsProWBxaGj+PzaPjWV9Q@mail.gmail.com (view raw or flat)
Thread:
Lists: pgsql-committerspgsql-hackers
On Sun, Jul 3, 2011 at 7:51 PM, Peter Eisentraut <peter_e(at)gmx(dot)net> wrote:
> On tor, 2011-06-30 at 15:09 -0400, Alvaro Herrera wrote:
>> Robert Hass (whose name I misspelled in the commit message above) just
>> mentioned to me (in an answer to my apologizing about it) that he
>> didn't think that mentioning sponsors for patch development was a good
>> idea.
>>
>> I don't think we have a policy for this, but I have done it for some
>> time now and nobody has complained, so I sort of assumed it was okay.
>> Besides, some of the people pouring the money in does care about it;
>> moreover, it provides a little incentive for other companies that
>> might also be in a position to fund development but lack the "peer
>> approval" of the idea, or a final little push.
>
> I think commit messages should be restricted to describing what was
> changed and who is responsible for it.  Once we open it for things like
> sponsorship, what's to stop people from adding personal messages, what
> they had for breakfast, "currently listening to", or just selling
> advertising space in each commit message for 99 cents?

Agreed.

We should credit people somewhere, but not here.

Otherwise, we'll be forced to add "Sponsored by RedHat", "Sponsored by
2ndQuadrant" etc onto commit messages.

-- 
 Simon Riggs                   http://www.2ndQuadrant.com/
 PostgreSQL Development, 24x7 Support, Training & Services

In response to

Responses

pgsql-hackers by date

Next:From: Michael GouldDate: 2011-07-03 20:30:30
Subject: Re: Full GUID support
Previous:From: Andres FreundDate: 2011-07-03 19:33:19
Subject: Re: Deriving release notes from git commit messages

pgsql-committers by date

Next:From: Tom LaneDate: 2011-07-03 20:41:00
Subject: pgsql: Back-patch creation of tar.bz2 tarball during "make dist".
Previous:From: Magnus HaganderDate: 2011-07-03 19:06:48
Subject: Re: [COMMITTERS] pgsql: Enable CHECK constraints to be declared NOT VALID

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group