Skip site navigation (1) Skip section navigation (2)

Re: [v9.2] make_greater_string() does not return a string in some cases

From: Robert Haas <robertmhaas(at)gmail(dot)com>
To: horiguchi(dot)kyotaro(at)oss(dot)ntt(dot)co(dot)jp
Cc: tgl(at)sss(dot)pgh(dot)pa(dot)us, pgsql-hackers(at)postgresql(dot)org
Subject: Re: [v9.2] make_greater_string() does not return a string in some cases
Date: 2011-10-29 18:26:28
Message-ID: CA+TgmobMOox8xVcJ62OoqfH5CQyBEm-2z4SFywwC-VgAtZDE_A@mail.gmail.com (view raw or flat)
Thread:
Lists: pgsql-bugspgsql-hackers
On Sat, Oct 29, 2011 at 1:16 PM,  <horiguchi(dot)kyotaro(at)oss(dot)ntt(dot)co(dot)jp> wrote:
> Hello, I feel at a loss what to do...
>
>> I thought that code was looking for 0xED/0xF4 in the second position,
>> but it's actually looking for them in the first position, which makes
>> vastly more sense.  Whee!
>
> Anyway, I try to describe another aspect of this code a the present.

I've committed this, after a good deal of hacking on the comments,
some coding style cleanup, and one bug fix:

+               workstr[len] = '\0';

Without that, when we start fiddling with the second-to-last
character, the last one is still hanging around, which is different
than the old behavior.

-- 
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

In response to

Responses

pgsql-hackers by date

Next:From: Erik RijkersDate: 2011-10-29 19:12:22
Subject:
Previous:From: horiguchi.kyotaroDate: 2011-10-29 17:16:03
Subject: Re: [v9.2] make_greater_string() does not return a string in some cases

pgsql-bugs by date

Next:From: Tom LaneDate: 2011-10-29 19:35:27
Subject: Re: [v9.2] make_greater_string() does not return a string in some cases
Previous:From: horiguchi.kyotaroDate: 2011-10-29 17:16:03
Subject: Re: [v9.2] make_greater_string() does not return a string in some cases

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group