Skip site navigation (1) Skip section navigation (2)

Re: psql describe.c cleanup

From: Robert Haas <robertmhaas(at)gmail(dot)com>
To: Merlin Moncure <mmoncure(at)gmail(dot)com>
Cc: Josh Kupershmidt <schmiddy(at)gmail(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: psql describe.c cleanup
Date: 2011-07-06 14:14:04
Message-ID: CA+TgmoZGVC_nFBTytHaYV=iyUga+6Ln-4LqztU1WdysnTYjvXQ@mail.gmail.com (view raw or flat)
Thread:
Lists: pgsql-hackers
On Thu, Jun 16, 2011 at 10:05 AM, Merlin Moncure <mmoncure(at)gmail(dot)com> wrote:
> On Wed, Jun 15, 2011 at 9:01 AM, Merlin Moncure <mmoncure(at)gmail(dot)com> wrote:
>> On Tue, Jun 14, 2011 at 9:08 PM, Josh Kupershmidt <schmiddy(at)gmail(dot)com> wrote:
>>> On Tue, Jun 14, 2011 at 12:15 PM, Merlin Moncure <mmoncure(at)gmail(dot)com> wrote:
>>>> What I do wonder though is if the ; appending should really be
>>>> happening in printQuery() instead of in each query -- the idea being
>>>> that formatting for external consumption should be happening in one
>>>> place.  Maybe that's over-thinking it though.
>>>
>>> That's a fair point, and hacking up printQuery() would indeed solve my
>>> original gripe about copy-pasting queries out of psql -E. But more
>>> generally, I think that standardizing the style of the code is a Good
>>> Thing, particularly where style issues impact usability (like here).
>>
>> sure -- if anyone would like to comment on this one way or the other
>> feel free -- otherwise I'll pass the patch up the chain as-is...it's
>> not exactly the 'debate of the century' :-).
>
> done.  marked ready for committer.

Committed.

-- 
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

In response to

pgsql-hackers by date

Next:From: Alexey KlyukinDate: 2011-07-06 14:24:52
Subject: Re: storing TZ along timestamps
Previous:From: Robert HaasDate: 2011-07-06 13:55:01
Subject: Re: Avoid index rebuilds for no-rewrite ALTER TABLE ALTER TYPE

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group