On Tue, Apr 10, 2012 at 9:17 PM, Guillaume Lelarge
> On Mon, 2012-04-09 at 19:58 +0530, Ashesh Vashi wrote:
>> On Sun, Apr 8, 2012 at 3:24 PM, Dave Page <dpage(at)pgadmin(dot)org> wrote:
>> > On Sun, Apr 8, 2012 at 4:44 AM, Guillaume Lelarge
>> > <guillaume(at)lelarge(dot)info> wrote:
>> > > Hi,
>> > >
>> > > I was trying to fix a bug on dlgDomain, and I found this code (in
>> > > pgadmin/schema/pgDomain.cpp):
>> > >
>> > > wxString conname = set->GetVal(wxT("conname"));
>> > > if (!conname.StartsWith(wxT("$")))
>> > > check += wxT("CONSTRAINT ") + qtIdent(conname) + wxT(" ");
>> > >
>> > > I'm wondering why we look for a dollar sign in the first character of a
>> > > check constraint in a domain. It means nothing to me. Could it be some
>> > > GreenPlum or EnterpriseDB specific code? or is it something else?
>> > Not that I recall - Ashesh, Sachin - do you know if it's a PPAS thing?
>> Not that I recall.
>> It's been there from very long time..
>> i.e. git log 6003c502d89900b2b2e1538d340db028b1880aa1 -p -n 1
> OK. I got rid of it, but I'm still working on enhancing the domains
> code. I now have a Constraints node under each domain object, and a new
> tab in dlgDomain to add as many constraints as you want (only check
> constraints of course). See screenshots attached.
> I still need to test it more thoroughly.
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
In response to
pgadmin-hackers by date
|Next:||From: Dave Page||Date: 2012-04-11 10:20:06|
|Subject: Re: PATCH: Error Message is displayed when the Package is Clicked in
pgAdmin (having functions with default parameters)|
|Previous:||From: Akshay Joshi||Date: 2012-04-11 06:22:05|
|Subject: Re: pgAdmin 1.15 experiences|