Skip site navigation (1) Skip section navigation (2)

Re: [pgadmin-support] Missing defaults for function arguments

From: Dave Page <dpage(at)pgadmin(dot)org>
To: Ashesh Vashi <ashesh(dot)vashi(at)enterprisedb(dot)com>
Cc: pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>, pgadmin-support(at)postgresql(dot)org, Michal Kozusznik <kozusznik(dot)michal(at)ifortuna(dot)cz>
Subject: Re: [pgadmin-support] Missing defaults for function arguments
Date: 2012-06-11 13:00:07
Message-ID: CA+OCxow28DHT6xtOzv6psV9kwg3UdV+WEqNZzisL0OtzKWkbjw@mail.gmail.com (view raw or flat)
Thread:
Lists: pgadmin-hackerspgadmin-support
On Sun, Jun 10, 2012 at 6:57 PM, Ashesh Vashi <ashesh(dot)vashi(at)enterprisedb(dot)com
> wrote:

> Hi Dave/Guillaume,
>
> Please find the attached patch to resolve this issue.
> In the following commit - the file was modified and we were not able to
> spot the issue earlier.
> a265fb2977253fce436e276320d337425639384c
>
> It can be applied to both branches - REL-1_14_0_PATCHES & master.
>
>
I'm not sure I see how this will work. From what I can see of the patch,
it'll use the column name proargdefvals for PPAS 8.3+ and proargdefaults
for PG. However;

- PPAS 8.3 uses proargdefvals
- PPAS 9.0 uses proargdefaults (I don't have 8.4 to hand, but I assume it
took the new PG naming)
- PostgreSQL uses proargdefaults.

So, shouldn't the code be something more like:

wxString defCol;

if (EdbMinimumVersion(8, 3))
{
    defCol = wxT("'proargdefvals'");
}

if (BackendMinimumVersion(8, 4))
{
    defCol = wxT("'proargdefaults'");
}

Please check PPAS 8.4, and update the patch accordingly (assuming you agree
with my comments).

-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

In response to

Responses

pgadmin-hackers by date

Next:From: Ashesh VashiDate: 2012-06-11 16:32:53
Subject: Re: [pgadmin-support] Missing defaults for function arguments
Previous:From: Ashesh VashiDate: 2012-06-10 17:57:48
Subject: Re: [pgadmin-support] Missing defaults for function arguments

pgadmin-support by date

Next:From: Ashesh VashiDate: 2012-06-11 16:32:53
Subject: Re: [pgadmin-support] Missing defaults for function arguments
Previous:From: Ashesh VashiDate: 2012-06-10 17:57:48
Subject: Re: [pgadmin-support] Missing defaults for function arguments

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group