Skip site navigation (1) Skip section navigation (2)

Re: [COMMITTERS] pgsql: Avoid assuming there will be only 3 states for synchronous_commi

From: Robert Haas <robertmhaas(at)gmail(dot)com>
To: Simon Riggs <simon(at)2ndquadrant(dot)com>
Cc: pgsql-hackers(at)postgresql(dot)org
Subject: Re: [COMMITTERS] pgsql: Avoid assuming there will be only 3 states for synchronous_commi
Date: 2011-04-04 23:10:42
Message-ID: BANLkTimq-YBiBQGZ5Ok5nKurJWSnDYiAXA@mail.gmail.com (view raw or flat)
Thread:
Lists: pgsql-committerspgsql-hackers
On Mon, Apr 4, 2011 at 6:24 PM, Simon Riggs <simon(at)2ndquadrant(dot)com> wrote:
> Avoid assuming there will be only 3 states for synchronous_commit.
> Also avoid hardcoding the current default state by giving it the name
> "on" and replace with a meaningful name that reflects its behaviour.
> Coding only, no change in behaviour.

I think changing the test to > SYNCHRONOUS_COMMIT_OFF is an
improvement, but I don't particularly like the renaming portion of
this change - now the internal names don't match what the user types,
which seems less clear, and inconsistent with every other enum-type
GUC.

-- 
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

In response to

pgsql-hackers by date

Next:From: Dan PortsDate: 2011-04-04 23:46:08
Subject: Re: time table for beta1
Previous:From: Robert HaasDate: 2011-04-04 23:04:59
Subject: Re: time table for beta1

pgsql-committers by date

Next:From: Shigeru HANADADate: 2011-04-05 04:37:48
Subject: Re: Re: [COMMITTERS] pgsql: Support comments on FOREIGN DATA WRAPPER and SERVER objects.
Previous:From: Simon RiggsDate: 2011-04-04 22:24:15
Subject: pgsql: Avoid assuming there will be only 3 states forsynchronous_commi

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group