Skip site navigation (1) Skip section navigation (2)

Re: pgsql: Add DISCARD to the command_no_begin list for AUTOCOMMIT=off.

From: Itagaki Takahiro <itagaki(dot)takahiro(at)gmail(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: pgsql-committers(at)postgresql(dot)org
Subject: Re: pgsql: Add DISCARD to the command_no_begin list for AUTOCOMMIT=off.
Date: 2010-09-28 06:45:09
Message-ID: AANLkTikqDgOYOOCz6hB88PBDMQ84nWUf8jDG27FTwFvE@mail.gmail.com (view raw or flat)
Thread:
Lists: pgsql-committers
On Tue, Sep 28, 2010 at 3:36 PM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> Itagaki Takahiro <itagaki(dot)takahiro(at)gmail(dot)com> writes:
>> Add DISCARD to the command_no_begin list for AUTOCOMMIT=off.
>
> This patch appears incorrect to me.  Only the DISCARD ALL variant is
> prohibited inside BEGIN, so why is it making all variants of DISCARD
> autocommittable?
>
> The DROP coding immediately above is a model for how to deal with
> two-word commands.

Oops, thanks. I'll fix it.

-- 
Itagaki Takahiro

In response to

pgsql-committers by date

Next:From: Itagaki TakahiroDate: 2010-09-28 06:59:22
Subject: pgsql: Only DISCARD ALL should be in the command_no_begin list.
Previous:From: Tom LaneDate: 2010-09-28 06:36:24
Subject: Re: pgsql: Add DISCARD to the command_no_begin list for AUTOCOMMIT=off.

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group