Skip site navigation (1) Skip section navigation (2)

Re: [COMMITTERS] pgsql: Allow copydir() to be interrupted.

From: Robert Haas <robertmhaas(at)gmail(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: pgsql-hackers(at)postgresql(dot)org, Magnus Hagander <magnus(at)hagander(dot)net>, Andrew Dunstan <andrew(at)dunslane(dot)net>
Subject: Re: [COMMITTERS] pgsql: Allow copydir() to be interrupted.
Date: 2010-07-02 16:38:56
Message-ID: AANLkTikhfT0glNIRuWSFC9YmL-Euflm9fnEGBzNbe5AS@mail.gmail.com (view raw or flat)
Thread:
Lists: pgsql-committerspgsql-hackers
On Fri, Jul 2, 2010 at 11:07 AM, Robert Haas <robertmhaas(at)gmail(dot)com> wrote:
> On Fri, Jul 2, 2010 at 10:21 AM, Robert Haas <robertmhaas(at)gmail(dot)com> wrote:
>> On Fri, Jul 2, 2010 at 10:18 AM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>>> Robert Haas <robertmhaas(at)gmail(dot)com> writes:
>>>>>> This appears to have broken MinGW and Cygwin builds on the buildfarm.
>>>>
>>>> Well, that's not awesome. IM-ing with Magnus now.  I'm wondering if
>>>> this is a link-ordering problem of some kind.
>>>
>>> Possibly an #ifndef FRONTEND will fix it.
>>
>> What's failing to link is postgres.exe
>
> I suspect that moving copydir.c into the backend will fix this, but I
> don't have an appropriate build environment to test.  Can someone
> please test the attached patch?

Andrew confirms that this works on mingw, so I'm going to go ahead and
check it in and see what happens.

-- 
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise Postgres Company

In response to

Responses

pgsql-hackers by date

Next:From: Andrew DunstanDate: 2010-07-02 16:39:18
Subject: Re: server authentication over Unix-domain sockets
Previous:From: David E. WheelerDate: 2010-07-02 16:36:10
Subject: Re: hstore ==> and deprecate =>

pgsql-committers by date

Next:From: Robert HaasDate: 2010-07-02 17:03:30
Subject: pgsql: Move copydir.c from src/port to src/backend/storage/file The
Previous:From: Robert HaasDate: 2010-07-02 15:07:10
Subject: Re: [COMMITTERS] pgsql: Allow copydir() to be interrupted.

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group