Skip site navigation (1) Skip section navigation (2)

Re: setlocale and gettext in Postgres

From: Dave Page <dpage(at)pgadmin(dot)org>
To: Magnus Hagander <magnus(at)hagander(dot)net>
Cc: Itagaki Takahiro <itagaki(dot)takahiro(at)gmail(dot)com>, Hiroshi Inoue <inoue(at)tpf(dot)co(dot)jp>, PG Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: setlocale and gettext in Postgres
Date: 2011-02-01 08:47:58
Message-ID: AANLkTikRzrxzSzibtXnNy=R96qz9BUhX7pJBQRPjmdS4@mail.gmail.com (view raw or flat)
Thread:
Lists: pgsql-hackers
On Tue, Feb 1, 2011 at 8:29 AM, Magnus Hagander <magnus(at)hagander(dot)net> wrote:
> On Tue, Feb 1, 2011 at 09:08, Dave Page <dpage(at)pgadmin(dot)org> wrote:
>> On Tue, Feb 1, 2011 at 5:36 AM, Itagaki Takahiro
>> <itagaki(dot)takahiro(at)gmail(dot)com> wrote:
>>> 2011/1/27 Hiroshi Inoue <inoue(at)tpf(dot)co(dot)jp>:
>>>> I see now the following lines in libintl.h of version
>>>> 0.18.1.1 which didn't exist in 0.17 version.
>>>>
>>>> The macro may cause a trouble especially on Windows.
>>>> Attached is a patch to disable the macro on Windows.
>>>
>>> Can anyone test the fix?
>>>
>>> I added the patch to the current commitfest for reminder.
>>> https://commitfest.postgresql.org/action/patch_view?id=528
>>
>> The QA team in EDB have tested the patch for me. It works as designed
>> and allows us to upgrade gettext to fix Japanese localisation on
>> Win64. Upgrading gettext without the patch will fix Japanese, but
>> break other translations (eg. French).
>
> Do we need to backpatch this?

We've only seen the problem on 64 bit builds - but I guess it may
occur on 32 bit too, given the right version of gettext (they come
form different places for win32 vs. win64, so it's not entirely
straightforward to figure out).

So, it certainly needs to go to 9.0, and probably wouldn't hurt to put
it in 8.3/8.4 too.

-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

In response to

Responses

pgsql-hackers by date

Next:From: Simon RiggsDate: 2011-02-01 09:36:19
Subject: Re: Error code for "terminating connection due to conflict with recovery"
Previous:From: YAMAMOTO TakashiDate: 2011-02-01 08:35:02
Subject: Re: [NOVICE] systable_getnext_ordered

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group