When running pg_basebackup with -x to include all transaction log, the
server will still throw a warning about xlog archiving if it's not
enabled - that is completely irrelevant since pg_basebackup has
included it already (and if it was gone, the base backup step itself
will fail - actual error and not warning).

This patch moves the warning from do_pg_base_backup to pg_base_backup,
so it still shows when using the explicit function calls, but goes
away when using pg_basebackup.

Objections?

-- 
 Magnus Hagander
 Me: http://www.hagander.net/
 Work: http://www.redpill-linpro.com/

Responses

• Re: Move WAL warning at 2011-02-02 16:43:59 from Heikki Linnakangas

pgsql-hackers by date

Next:	From: Dimitri Fontaine	Date: 2011-02-02 14:45:45
	Subject: Re: ALTER EXTENSION UPGRADE, v3
Previous:	From: Heikki Linnakangas	Date: 2011-02-02 14:30:30
	Subject: Re: SSI patch version 14