Skip site navigation (1) Skip section navigation (2)

Move WAL warning

From: Magnus Hagander <magnus(at)hagander(dot)net>
To: PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Move WAL warning
Date: 2011-02-02 14:36:51
Message-ID: AANLkTik+6bvUq=qhv8Xwe4ow99gH4MVzshF-DF=Wr64D@mail.gmail.com (view raw or flat)
Thread:
Lists: pgsql-hackers
When running pg_basebackup with -x to include all transaction log, the
server will still throw a warning about xlog archiving if it's not
enabled - that is completely irrelevant since pg_basebackup has
included it already (and if it was gone, the base backup step itself
will fail - actual error and not warning).

This patch moves the warning from do_pg_base_backup to pg_base_backup,
so it still shows when using the explicit function calls, but goes
away when using pg_basebackup.

Objections?

-- 
 Magnus Hagander
 Me: http://www.hagander.net/
 Work: http://www.redpill-linpro.com/

Attachment: stop_backup_warning.patch
Description: text/x-patch (1.0 KB)

Responses

pgsql-hackers by date

Next:From: Dimitri FontaineDate: 2011-02-02 14:45:45
Subject: Re: ALTER EXTENSION UPGRADE, v3
Previous:From: Heikki LinnakangasDate: 2011-02-02 14:30:30
Subject: Re: SSI patch version 14

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group