Skip site navigation (1) Skip section navigation (2)

Re: phase 2 of wxWidgets 2.9 build

From: Peter Geoghegan <peter(dot)geoghegan86(at)gmail(dot)com>
To: Dave Page <dpage(at)pgadmin(dot)org>
Cc: pgadmin-hackers(at)postgresql(dot)org
Subject: Re: phase 2 of wxWidgets 2.9 build
Date: 2011-02-03 03:00:25
Message-ID: AANLkTi=Ez9ouw9hsonkryKF_qs2cs6hwT-m8R-UvXz19@mail.gmail.com (view raw or flat)
Thread:
Lists: pgadmin-hackers
On 2 February 2011 18:51, Dave Page <dpage(at)pgadmin(dot)org> wrote:
>> so that the wxClientData* overload rather than the void* overload is
>> called seems to have fixed the problem.
>
> Yup.

The problem is that the c style cast is equivalent to a
reinterpret_cast<>() (part of the reason why I avoid C style casts in
C++). We're technically resorting to undefined behaviour here. Time to
ping the wx guys about the linker thing I suppose. It might be fixed
in wx SVN. I'll check tomorrow.

>> We have a complete 2.9 build!
>
> Wahoo! Nice work Sir!

Thanks.

I'm going to clean up your commit from the other day per your
suggestion. I'm also going to get started on moving OGL into the tree,
and building it ourselves.

I've noticed that the sample OGL applications have obvious bugs in
them, probably because of my cursory fixes to get them to work against
2.9. I wasn't too worried about it at the time. Should I be now? I'll
certainly want to clean up numerous OGL compiler warnings.

I'm seeing some errors like this:

An error has occurred:

XRC error: file:/home/peter/pgadmin3/pgadmin/ui/dlgTable.xrc:6:
unknown style flag "wxRESIZE_BOX"

...and...

An error has occurred:

XRC error: file:/home/peter/pgadmin3/pgadmin/ui/frmHint.xrc:6: unknown
style flag "wxTHICK_FRAME"

Any suggestions on a good place to attack to remove the probable AUI
related weirdness? Sometimes the "Object browser" header (i.e. where
it says object browser) isn't visible. the other panes seem unaffected
though. Object browser seems well behaved when docked anywhere other
than its default position.

There's this too, which I see when I start the SQL editor:

Program received signal SIGSEGV, Segmentation fault.
0x0000000000460063 in wxWindowBase::GetSize (this=0xd9d9abab8686)
    at /usr/local/include/wx-2.9/wx/window.h:321
321	        DoGetSize(& w, & h);
(gdb) bt
#0  0x0000000000460063 in wxWindowBase::GetSize (this=0xd9d9abab8686)
    at /usr/local/include/wx-2.9/wx/window.h:321
#1  0x00000000008024b1 in gqbSplitter::onVerticalSashResize (this=0x18bbb40,
    event=...) at ./gqb/gqbController.cpp:596
#2  0x00007ffff577349d in
wxAppConsoleBase::CallEventHandler(wxEvtHandler*, wxEventFunctor&,
wxEvent&) const () from /usr/local/lib/libwx_baseu-2.9.so.1
#3  0x00007ffff598dcf1 in
wxEvtHandler::ProcessEventIfMatchesId(wxEventTableEntryBase const&,
wxEvtHandler*, wxEvent&) ()
   from /usr/local/lib/libwx_baseu-2.9.so.1
#4  0x00007ffff598de53 in wxEventHashTable::HandleEvent(wxEvent&,
wxEvtHandler*) () from /usr/local/lib/libwx_baseu-2.9.so.1
#5  0x00007ffff598e1e3 in wxEvtHandler::ProcessEventLocally(wxEvent&) ()
   from /usr/local/lib/libwx_baseu-2.9.so.1
#6  0x00007ffff598e25d in wxEvtHandler::ProcessEvent(wxEvent&) ()
   from /usr/local/lib/libwx_baseu-2.9.so.1
#7  0x00007ffff65fb611 in wxSplitterWindow::DoSendEvent(wxSplitterEvent&) ()
   from /usr/local/lib/libwx_gtk2u_core-2.9.so.1
#8  0x00007ffff65fbce9 in wxSplitterWindow::SetSashPositionAndNotify(int) ()
   from /usr/local/lib/libwx_gtk2u_core-2.9.so.1
#9  0x00007ffff65fbeb9 in wxSplitterWindow::OnSize(wxSizeEvent&) ()
   from /usr/local/lib/libwx_gtk2u_core-2.9.so.1

I see this, which prevents me from calling the edit table dialog:

An error has occurred:

XRC error: file:/home/peter/pgadmin3/pgadmin/ui/dlgTable.xrc:330: too
many children in grid sizer: 36 > 3 x 11 (consider omitting the number
of rows or columns)

I expect to fix quite a few bugs tomorrow. My feeling is that we're
past the worst of it though. I'd like to close phase 2 by having a
pgAdmin III that builds against 2.9 with no obvious defects, but
doesn't yet have OGL in the tree. We'll then have something to commit
before moving on to phase 3, bringing OGL into the pgAdmin tree and
building it ourselves. Thoughts?

-- 
Regards,
Peter Geoghegan

In response to

Responses

pgadmin-hackers by date

Next:From: Dave PageDate: 2011-02-03 10:15:31
Subject: Re: phase 2 of wxWidgets 2.9 build
Previous:From: Dave PageDate: 2011-02-02 20:16:33
Subject: pgAdmin III commit: Fix a couple of warnings on VC++

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group