Skip site navigation (1) Skip section navigation (2)

Win32 regression test status

From: Claudio Natoli <claudio(dot)natoli(at)memetrics(dot)com>
To: "'pgsql-hackers-win32(at)postgresql(dot)org'" <pgsql-hackers-win32(at)postgresql(dot)org>
Cc: pgsql-hackers(at)postgresql(dot)org
Subject: Win32 regression test status
Date: 2004-02-24 11:11:05
Message-ID: A02DEC4D1073D611BAE8525405FCCE2B55F31C@harris.memetrics.local (view raw or flat)
Thread:
Lists: pgsql-hackerspgsql-hackers-win32pgsql-patches
Hi all,

my next TODO item for the Win32 port was to try to bring all the regression
tests up. 

Pleased to report that, with a great deal of hackage + kludges (which I hope
to refine and submit as patches for review over the next couple weeks), all
but 10 tests pass!

7 of these fail pretty much *only* due to localtime returning NULL for
pre-1970 dates, specifically: date, timestamp, timestampz, abstime,
tinterval, horology, arrays. To resolve this, seems like there are 3
solutions:

a) Provide "post-1970-only" versions of the expected regression test output,
for use under win32
b) Remove pre-1970 dates from *all* regression test files
c) Code up "pg_localtime" for win32

None of these are appealing, particularly b). Any better ideas?


With this issue aside, that leaves three tests remaining for examination:
join, rules and stats. The regression diffs are attached. 

The join and rules failures don't look material, AFAICS, as the right rows
are returned, just not necessarily in the expected order... is this an
issue? Is the order mandated in these cases. Again, afaIcs, it isn't, but
strictly I'm out of my depth here.

This leaves the stats test as possibly the only real remaining failure. An
analysis (collector not running?) based on the diff would be appreciated, as
well as pointers to which lines of code/functions one would expect to see
invoked if this test was running correctly, to help debugging.

Cheers,
Claudio


--- 
Certain disclaimers and policies apply to all email sent from Memetrics.
For the full text of these disclaimers and policies see 
<a
href="http://www.memetrics.com/emailpolicy.html">http://www.memetrics.com/em
ailpolicy.html</a>
  


Attachment: regression.diffs
Description: application/octet-stream (8.6 KB)

Responses

pgsql-hackers by date

Next:From: Joerg HessdoerferDate: 2004-02-24 11:42:10
Subject: Re: [HACKERS] Win32 regression test status
Previous:From: Jan WieckDate: 2004-02-24 11:08:36
Subject: Re: bgwriter never dies

pgsql-patches by date

Next:From: Joerg HessdoerferDate: 2004-02-24 11:42:10
Subject: Re: [HACKERS] Win32 regression test status
Previous:From: Claudio NatoliDate: 2004-02-24 08:39:22
Subject: win32 int/float test fixes

pgsql-hackers-win32 by date

Next:From: Joerg HessdoerferDate: 2004-02-24 11:42:10
Subject: Re: [HACKERS] Win32 regression test status
Previous:From: Claudio NatoliDate: 2004-02-18 22:34:26
Subject: Re: Win32 mingw libpq.dll

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group