2010/2/16 Fujii Masao <masao(dot)fujii(at)gmail(dot)com>:
> On Tue, Feb 16, 2010 at 1:33 AM, Magnus Hagander <magnus(at)hagander(dot)net> wrote:
>> 2010/2/15 Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>:
>>> Magnus Hagander <magnus(at)hagander(dot)net> writes:
>>>> I changed your patch to this, because I find it a lot simpler. The
>>>> change is in the checking in pgwin32_recv - there is no need to ever
>>>> call waitforsinglesocket, we can just exit out early.
> Thanks a lot, Magnus!
>>>> Do you see any issue with that?
>>> This definitely looks cleaner, but is there a reason not to use bool
>>> instead of int here?
> Can include/port/win32.h refer to bool type?
Nope, you're correct, it can't.
Committed without that.
In response to
pgsql-hackers by date
|Next:||From: Merlin Moncure||Date: 2010-02-16 19:34:28|
|Subject: Re: LISTEN/NOTIFY and notification timing guarantees|
|Previous:||From: Jakub Ouhrabka||Date: 2010-02-16 19:16:46|
|Subject: Re: Problem with 8.4 stats collector high load|