Skip site navigation (1) Skip section navigation (2)

Re: pgsql: PG_MAJORVERSION: For simplicity, use PG_MAJORVERSION rather than

From: Magnus Hagander <magnus(at)hagander(dot)net>
To: Bruce Momjian <bruce(at)momjian(dot)us>
Cc: Alvaro Herrera <alvherre(at)commandprompt(dot)com>, pgsql-committers <pgsql-committers(at)postgresql(dot)org>
Subject: Re: pgsql: PG_MAJORVERSION: For simplicity, use PG_MAJORVERSION rather than
Date: 2010-01-07 10:28:16
Message-ID: 9837222c1001070228l5365b4e2p15f287bd74644d50@mail.gmail.com (view raw or flat)
Thread:
Lists: pgsql-committers
On Thu, Jan 7, 2010 at 04:41, Bruce Momjian <bruce(at)momjian(dot)us> wrote:
> Alvaro Herrera wrote:
>> Bruce Momjian wrote:
>> > Alvaro Herrera wrote:
>>
>> > > I think this is a bad style to use for commit messages.  For GIT, a good
>> > > commit message is a first line being a summary, and a more extensive
>> > > message below.
>> >
>> > That is just too odd. I think I forgot about the summary idea then.
>>
>> What is odd?
>>
>> If I was unclear, look at this status page:
>>
>> http://git.postgresql.org/gitweb?p=postgresql.git;a=shortlog
>>
>> Note that for your commit it only says "PG_MAJORVERSION:".  You have to
>> open the patch's page to see the rest of the message.
>
> Well, having the description and then a blank line in the middle just is
> too odd for too small a group of viewers.  I might as well just type the
> commit message as normal and users can see all they can.

"small group"? I think you are definitely underestimating the number
of people who use the git interface to view the logs these days.

And frankly, if you're not using it yourself, you should seriously
look at it. It's vastly superior to the cvsweb interface. (And as I've
already shown you, if you're doing it locally on the commandline, then
it's *very* much nicer and faster than cvs there as well)

-- 
 Magnus Hagander
 Me: http://www.hagander.net/
 Work: http://www.redpill-linpro.com/

In response to

Responses

pgsql-committers by date

Next:From: Bruce MomjianDate: 2010-01-07 12:38:55
Subject: pgsql: Rename new vacuumdb option to --analyze-only from --only-analyze.
Previous:From: User ItagakiDate: 2010-01-07 07:59:37
Subject: pgbulkload - pgbulkload: Refine messages and option handleing routines

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group