Skip site navigation (1) Skip section navigation (2)

Re: restore to defaults values when commenting of variables in postgresql.conf

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: BERTHOULE Emmanuel <pgdev(at)manberth(dot)homeip(dot)net>
Cc: pgsql-patches(at)postgresql(dot)org
Subject: Re: restore to defaults values when commenting of variables in postgresql.conf
Date: 2006-03-29 21:37:52
Message-ID: 947.1143668272@sss.pgh.pa.us (view raw or flat)
Thread:
Lists: pgsql-patches
BERTHOULE Emmanuel <pgdev(at)manberth(dot)homeip(dot)net> writes:
> with this patch, you can now restore default value with SIGHUP when
> commenting an variable in postgresql.conf

This seems pretty poorly thought out, in particular making PGC_S_SIGHUP
>= PGC_S_OVERRIDE seems to me likely to break the interaction with other
sources.  Doesn't that cause postgresql.conf to override per-user and
per-database settings?  Why do you need the extra value at all ---
isn't the correct logic just to reset entries with source PGC_S_FILE?

Another problem is that if there's something wrong with the config file,
this will cause all values previously read from the config file to
revert to defaults, which seems less than robust to me.  You really
shouldn't apply the reset until after the file has been parsed.

			regards, tom lane

In response to

Responses

pgsql-patches by date

Next:From: David FetterDate: 2006-03-29 22:25:08
Subject: Re: Win32 sysconfig -> pg_service.conf
Previous:From: Steve WoodcockDate: 2006-03-29 21:11:08
Subject: Re: Improve psql's handling of multi-line queries

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group