Skip site navigation (1) Skip section navigation (2)

Re: First public pre-alpha release of GQB (Graphical Query Builder) for pgAdmin

From: "Dave Page" <dpage(at)pgadmin(dot)org>
To: "Luis Ochoa" <ziul1979(at)gmail(dot)com>
Cc: pgadmin-hackers(at)postgresql(dot)org
Subject: Re: First public pre-alpha release of GQB (Graphical Query Builder) for pgAdmin
Date: 2008-08-04 08:26:01
Message-ID: 937d27e10808040126h46810988h68294d0169998c20@mail.gmail.com (view raw or flat)
Thread:
Lists: pgadmin-hackers
Hi Luis

On Sun, Jul 27, 2008 at 6:13 AM, Luis Ochoa <ziul1979(at)gmail(dot)com> wrote:
>
> Where is located the patch?
> http://svn.assembla.com/svn/vsqlbuilder/Jul/27/prealpha-test-gqb-july-27.patch

I'm just going to list all the issues I found here so you can work
through them easily. I'm testing on a Mac today, and feeling
particularly pedantic :-p.

- The patch failed to apply frmQuery.h. During manual application, I
found that you have app headers inbetween wx headers (wx headers
should always be first), and a wx header quoted with " " instead of <
>.

- Some compilation warnings:

./frm/frmQuery.cpp: In constructor 'frmQuery::frmQuery(frmMain*, const
wxString&, pgConn*, const wxString&, const wxString&)':
./frm/frmQuery.cpp:368: warning: unused variable 'view'
./frm/frmQuery.cpp: In constructor 'frmQuery::frmQuery(frmMain*, const
wxString&, pgConn*, const wxString&, const wxString&)':
./frm/frmQuery.cpp:368: warning: unused variable 'view'
./frm/frmQuery.cpp: In member function 'void
frmQuery::OnChangeConnection(wxCommandEvent&)':
./frm/frmQuery.cpp:881: warning: cannot pass objects of non-POD type
'class wxString' through '...'; call will abort at runtime
./frm/frmQuery.cpp: In member function 'void
frmQuery::OnTest3(wxNotebookEvent&)':
./frm/frmQuery.cpp:1027: warning: cannot pass objects of non-POD type
'class wxString' through '...'; call will abort at runtime
./frm/frmQuery.cpp: In member function 'void
frmQuery::OnChangeConnection(wxCommandEvent&)':
./frm/frmQuery.cpp:881: warning: cannot pass objects of non-POD type
'class wxString' through '...'; call will abort at runtime
./frm/frmQuery.cpp: In member function 'void
frmQuery::OnTest3(wxNotebookEvent&)':
./frm/frmQuery.cpp:1027: warning: cannot pass objects of non-POD type
'class wxString' through '...'; call will abort at runtime

(The last four *will* cause crashes - normally you just add .c_str()
to any wxString arguments passed as arguments to variadic functions).

<hits brick wall>

Following that, I ran into the same errors as Guillaume. Please supply
an updated patch, that uses only wxWidgets controls (using GTK classes
definitely isn't going to work on Mac).

-- 
Dave Page
EnterpriseDB UK: http://www.enterprisedb.com

In response to

Responses

pgadmin-hackers by date

Next:From: Dave PageDate: 2008-08-04 10:03:34
Subject: Re: pgScript patch
Previous:From: Guillaume LelargeDate: 2008-08-01 21:46:17
Subject: Re: Dialogs review

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group