Skip site navigation (1) Skip section navigation (2)

Re: Enabling SQL text field in the SQL tab of object dialog

From: "Dave Page" <dpage(at)postgresql(dot)org>
To: "Guillaume Lelarge" <guillaume(at)lelarge(dot)info>
Cc: pgadmin-hackers(at)postgresql(dot)org
Subject: Re: Enabling SQL text field in the SQL tab of object dialog
Date: 2008-06-16 20:40:51
Message-ID: 937d27e10806161340w7799dd6dpb1ba6387fb22c39a@mail.gmail.com (view raw or flat)
Thread:
Lists: pgadmin-hackers
On Mon, Jun 16, 2008 at 9:34 PM, Guillaume Lelarge
<guillaume(at)lelarge(dot)info> wrote:

> Option 1 seems not very user friendly to me. Are you against option 2? if
> yes, why?

Yes, because it's inconsistent to offer the feature in all but two
dialogues. With option 1, the worst that will happen is the user will
get an error if they mix tx-sfe and non tx-safe ddl in the one box.
It'll be handled gracefully by pgAdmin though, so they c an easily
edit and try again. Plus we can include a short comment in the
generated SQL to explain the split; something like:

-- This statement is executed on it's own because it is not transaction safe.
CREATE DATABASE foo;

-- 
Dave Page
EnterpriseDB UK:   http://www.enterprisedb.com

In response to

Responses

pgadmin-hackers by date

Next:From: svnDate: 2008-06-16 20:55:30
Subject: SVN Commit by guillaume: r7376 - in trunk/pgadmin3/pgadmin: dlg include/dlg include/schema ui
Previous:From: Guillaume LelargeDate: 2008-06-16 20:34:33
Subject: Re: Enabling SQL text field in the SQL tab of object dialog

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group