Re: Patch for not going beyond NOFILE system limit

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
Cc: Martin Pitt <martin(at)piware(dot)de>, pgsql-bugs(at)postgresql(dot)org
Subject: Re: Patch for not going beyond NOFILE system limit
Date: 2004-05-19 00:12:39
Message-ID: 9377.1084925559@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-bugs

Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us> writes:
> We have already fixed this in CVS and the fix will be in 7.5:

I don't think that the previous changes address what the complainant
seems to really want, viz not even *try* to exceed RLIMIT_NOFILE.

However the patch certainly must be rejected since (a) it appears
unaware of the post-7.4 work in this area, (b) it has not been made
portable (eg, it will fail to compile on machines without getrlimit),
and (c) we do not like patches that add random manual configuration
symbols to the code ... especially undocumented ones.

If this issue seems important to you then please rework the patch to be
up-to-date and properly autoconfiscated, and resubmit.

regards, tom lane

In response to

Browse pgsql-bugs by date

  From Date Subject
Next Message yruhn 2004-05-19 07:37:26 Re: BUG #1154: no python interface anymore
Previous Message Tom Lane 2004-05-18 22:59:19 Re: BUG #1145: silent REVOKE failures