Re: ruleutils with pretty-print option

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
Cc: Andreas Pflug <pgadmin(at)pse-consulting(dot)de>, pgsql-patches(at)postgresql(dot)org
Subject: Re: ruleutils with pretty-print option
Date: 2003-07-27 16:17:16
Message-ID: 8978.1059322636@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-patches

Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us> writes:
> Are these illustrating a problem with the function definition, or is it
> happening because it is the first time we are calling the same function
> with one and more than one parameter?

The function definition is broken. While it could be fixed (by
explicitly testing fcinfo->nargs, rather than assuming positions
beyond nargs are valid) I am not willing to remove the opr_sanity
check that is complaining. Accordingly, a better solution would be
to make two C-code wrapper functions, one for the single-parameter
and one for the two-parameter case of each function.

regards, tom lane

In response to

Responses

Browse pgsql-patches by date

  From Date Subject
Next Message Troels Arvin 2003-07-27 18:33:25 Added comments to postgresql.conf file
Previous Message Tom Lane 2003-07-27 15:40:57 Re: [HACKERS] PATCH: Memory leaks on start-up