Skip site navigation (1) Skip section navigation (2)

Re: Re: [COMMITTERS] pgsql: Start background writer during archive recovery.

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Heikki Linnakangas <heikki(dot)linnakangas(at)enterprisedb(dot)com>
Cc: Simon Riggs <simon(at)2ndQuadrant(dot)com>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: Re: [COMMITTERS] pgsql: Start background writer during archive recovery.
Date: 2009-02-19 16:22:53
Message-ID: 8929.1235060573@sss.pgh.pa.us (view raw or flat)
Thread:
Lists: pgsql-committerspgsql-hackers
Heikki Linnakangas <heikki(dot)linnakangas(at)enterprisedb(dot)com> writes:
> Tom Lane wrote:
>> Maybe the postmaster should wait for startup process exit before
>> deciding to open for business, instead of just a signal.

> Not a bad idea. Although, there's nothing wrong with the current way 
> either. The startup process does a proc_exit(0) right after sending the 
> signal ATM, so there's no real work left at that point.

The thing wrong with it is assuming that nothing interesting will happen
during proc_exit().  We hang enough stuff on on_proc_exit hooks that
that seems like a pretty shaky assumption.

			regards, tom lane

In response to

Responses

pgsql-hackers by date

Next:From: Tom LaneDate: 2009-02-19 16:25:50
Subject: Re: autovacuum not honoring pg_autovacuum in 8.3.5?
Previous:From: Heikki LinnakangasDate: 2009-02-19 16:20:22
Subject: Re: Re: [COMMITTERS] pgsql: Start background writer during archive recovery.

pgsql-committers by date

Next:From: Heikki LinnakangasDate: 2009-02-19 16:43:13
Subject: pgsql: Fix bogus comment, from the patch to start bgwriter during
Previous:From: Heikki LinnakangasDate: 2009-02-19 16:20:22
Subject: Re: Re: [COMMITTERS] pgsql: Start background writer during archive recovery.

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group