"Tom Lane" <tgl(at)sss(dot)pgh(dot)pa(dot)us> writes:
> Any objections to applying the patch?
I like applying it.
You don't include any negative tests and corner cases as well; cases where the
new code shouldn't be disturbing the results such as a symmetric join or a
join against a single-row table. The comments make me think you ran them but
just didn't show them though.
What about a merge join against an empty table? I suppose there would just be
Ask me about EnterpriseDB's 24x7 Postgres support!
In response to
pgsql-patches by date
|Next:||From: Magnus Hagander||Date: 2007-12-07 12:49:33|
|Subject: Re: Problem with ControlFileData structure being ABI depe
|Previous:||From: Simon Riggs||Date: 2007-12-07 08:29:35|
|Subject: Re: Proposed patch to make mergejoin cost estimationmore symmetric|