Re: [PATCHES] GIN improvements

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Alvaro Herrera <alvherre(at)commandprompt(dot)com>
Cc: Teodor Sigaev <teodor(at)sigaev(dot)ru>, Jeff Davis <pgsql(at)j-davis(dot)com>, Heikki Linnakangas <heikki(dot)linnakangas(at)enterprisedb(dot)com>, Pgsql Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [PATCHES] GIN improvements
Date: 2009-01-19 18:00:26
Message-ID: 8325.1232388026@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers pgsql-patches

Alvaro Herrera <alvherre(at)commandprompt(dot)com> writes:
> Teodor Sigaev wrote:
>> I didn't change a recognition of fillfactor value, although GIN doesn't
>> use it for now.

> I suggest you take StdRdOptions out of the GinOptions struct, and leave
> fillfactor out of ginoptions. I don't think there's much point in
> supporting options that don't actually do anything. If the user tries
> to set fillfactor for a gin index, he will get an error. Which is a
> good thing IMHO.

+1 ... appearing to accept an option that doesn't really do anything is
likely to confuse users. We didn't have much choice in the previous
incarnation of reloptions, but I think now we should throw errors when
we can.

regards, tom lane

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Jeff Davis 2009-01-19 18:02:40 Re: Review: B-Tree emulation for GIN
Previous Message Teodor Sigaev 2009-01-19 17:45:16 Re: tsearch with Turkish locale ( was Re: foreign_data test fails with non-C locale)

Browse pgsql-patches by date

  From Date Subject
Next Message Teodor Sigaev 2009-01-19 18:15:57 Re: [PATCHES] GIN improvements
Previous Message Alvaro Herrera 2009-01-19 17:20:19 Re: [PATCHES] GIN improvements