Re: small explain patch

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Liam Stewart <liams(at)redhat(dot)com>
Cc: PostgreSQL Patches List <pgsql-patches(at)postgresql(dot)org>
Subject: Re: small explain patch
Date: 2002-05-03 15:58:42
Message-ID: 8096.1020441522@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-patches

Liam Stewart <liams(at)redhat(dot)com> writes:
>> How would you feel about quoting only if necessary
>> (cf. quote_identifier)?

> That would work nicely. I didn't put the call to quote_identifier inside
> the stringStringInfo macro.

Actually, stringStringInfo seems entirely pointless here; the result of
RelationGetRelationName can't be NULL. The other places where it's
being used seem pointless as well. I removed it while applying your
patch...

regards, tom lane

In response to

Browse pgsql-patches by date

  From Date Subject
Next Message Neil Conway 2002-05-03 16:12:41 fix for typo in docs
Previous Message Liam Stewart 2002-05-03 14:22:30 Re: small explain patch