Skip site navigation (1) Skip section navigation (2)

Advisory locks seem rather broken

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: pgsql-hackers(at)postgreSQL(dot)org
Cc: Itagaki Takahiro <itagaki(dot)takahiro(at)gmail(dot)com>
Subject: Advisory locks seem rather broken
Date: 2012-05-03 00:19:27
Message-ID: 7555.1336004367@sss.pgh.pa.us (view raw or flat)
Thread:
Lists: pgsql-hackers
According to
http://archives.postgresql.org/pgsql-general/2012-04/msg00374.php
advisory locks now cause problems for prepared transactions, which
ought to ignore them.  It appears to me that this got broken by
commit 62c7bd31c8878dd45c9b9b2429ab7a12103f3590, which marked the
userlock lock method as transactional, which seems just about 100%
misguided to me.  At the very least this would require reconsidering
every single place that tests lock transactionality, and that evidently
did not happen.

If this patch weren't already in a released branch I would be arguing
for reverting it.  As is, I think we're going to have to clean it up.
I don't have time to look at it in detail right now, though.

			regards, tom lane

Responses

pgsql-hackers by date

Next:From: Robert HaasDate: 2012-05-03 00:41:29
Subject: Re: Latch for the WAL writer - further reducing idle wake-ups.
Previous:From: Michael PaquierDate: 2012-05-02 23:27:54
Subject: Re: [HACKERS] Features of Postgresql and Postgres-xc with MySQL

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group