Skip site navigation (1) Skip section navigation (2)

Re: [HACKERS] Function structure in formatting.c

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: "Brendan Jurd" <direvus(at)gmail(dot)com>
Cc: pgsql-patches(at)postgresql(dot)org
Subject: Re: [HACKERS] Function structure in formatting.c
Date: 2008-03-22 21:02:09
Message-ID: 7344.1206219729@sss.pgh.pa.us (view raw or flat)
Thread:
Lists: pgsql-hackerspgsql-patches
"Brendan Jurd" <direvus(at)gmail(dot)com> writes:
> I noticed an editing error in the patch I originally submitted; it
> defined the same debugging macro twice.
> I've attached a fresh copy of the patch against the current HEAD with
> the fix included.

Working through this patch now.  I found one thing that seems to be
a mistake (probably an overenthusiastic search&replace): the patch
changes
-	{"iy", 2, dch_date, DCH_IY, TRUE},
to
+	{"iyear", 2, DCH_IY, TRUE},

The removal of dch_date is intended, but surely the keyword should
still be "iy".  I'm proceeding on that assumption, but if this change
was actually intended, please explain.

			regards, tom lane

In response to

Responses

pgsql-hackers by date

Next:From: Tom LaneDate: 2008-03-22 22:32:51
Subject: Re: [HACKERS] Function structure in formatting.c
Previous:From: Mihai CrivetiDate: 2008-03-22 20:40:15
Subject: Building PostgreSQL 8.3.1 on OpenVMS 8.3 AXP

pgsql-patches by date

Next:From: Tom LaneDate: 2008-03-22 22:32:51
Subject: Re: [HACKERS] Function structure in formatting.c
Previous:From: Luke LonerganDate: 2008-03-22 05:35:17
Subject: Re: Auto Partitioning Patch - WIP version 1

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group