Skip site navigation (1) Skip section navigation (2)

Re: pgsql: Adjust basebackup.c to suppress compiler warnings.

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Magnus Hagander <magnus(at)hagander(dot)net>
Cc: pgsql-committers(at)postgresql(dot)org
Subject: Re: pgsql: Adjust basebackup.c to suppress compiler warnings.
Date: 2011-01-11 19:44:04
Message-ID: 7161.1294775044@sss.pgh.pa.us (view raw or flat)
Thread:
Lists: pgsql-committers
Magnus Hagander <magnus(at)hagander(dot)net> writes:
> On Tue, Jan 11, 2011 at 19:42, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>> Some versions of gcc complain about "variable `tablespaces' might be
>> clobbered by `longjmp' or `vfork'" with the original coding. Fix by
>> moving the PG_TRY block into a separate subroutine.

> I noticed you didn't create a function prototype at the top of the
> file for this function. Was that intentional, or missed? If it was
> intentional, can you give me a quick lesson in when it should be done
> and whe nit shouldn't? :-)

Oh, I just missed that you had ones for all the others.  Feel free to
add it.

			regards, tom lane

In response to

Responses

pgsql-committers by date

Next:From: Alvaro HerreraDate: 2011-01-11 20:00:05
Subject: Re: pgsql: Adjust basebackup.c to suppress compiler warnings.
Previous:From: Magnus HaganderDate: 2011-01-11 19:06:39
Subject: Re: pgsql: Adjust basebackup.c to suppress compiler warnings.

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group