Skip site navigation (1) Skip section navigation (2)

Re: Regression - GNUmakefile - pg_usleep

From: "Rocco Altier" <RoccoA(at)Routescape(dot)com>
To: "Rocco Altier" <RoccoA(at)Routescape(dot)com>,"Tom Lane" <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: "Patches (PostgreSQL)" <pgsql-patches(at)postgresql(dot)org>
Subject: Re: Regression - GNUmakefile - pg_usleep
Date: 2005-07-24 17:19:24
Message-ID: 6E0907A94904D94B99D7F387E08C4F5730ECB3@FALCON.INSIGHT (view raw or flat)
Thread:
Lists: pgsql-patches
This time I actually have the patches :-)

	-rocco

> -----Original Message-----
> From: pgsql-patches-owner(at)postgresql(dot)org 
> [mailto:pgsql-patches-owner(at)postgresql(dot)org] On Behalf Of Rocco Altier
> Sent: Sunday, July 24, 2005 1:15 PM
> To: Tom Lane
> Cc: Patches (PostgreSQL)
> Subject: Re: [PATCHES] Regression - GNUmakefile - pg_usleep 
> 
> 
> 
> 
> > -----Original Message-----
> > From: pgsql-patches-owner(at)postgresql(dot)org 
> > [mailto:pgsql-patches-owner(at)postgresql(dot)org] On Behalf Of Tom Lane
> > Sent: Sunday, July 24, 2005 10:47 AM
> > To: Rocco Altier
> > Cc: Patches (PostgreSQL)
> > Subject: Re: [PATCHES] Regression - GNUmakefile - pg_usleep 
> > 
> > 
> > "Rocco Altier" <RoccoA(at)Routescape(dot)com> writes:
> > > Attached patch fixes the SHLIB_LINK to add pgport now that 
> > pg_usleep is
> > > added.
> > 
> > It seems highly unlikely that this will accomplish anything, 
> > given that
> > SHLIB_LINK is not used to construct regress.so.
> > 
> I have another patch in queue for this.
> 
> > > This is needed for AIX to resolve symbols at compile time.
> > 
> > I'm still wondering why that platform has such a hard time finding
> > symbols that are in the backend.
> > 
> Right now there are 2 different sets of linker rules.  One 
> for a single
> file -> .so (from Makefile.aix), and another for multiple files ->
> lib<files>.so (from Makefile.shlib).
> 
> The patch I proposed to Makefile.shlib to pull all $LIBS in 
> was rejected
> since this would cause libpq to link against backend libraries, etc.
> The suggested solution was to only pull in libraries as 
> needed (which is
> what is happening here, since pgport would be required).
> 
> I think the 2 sets of link rules should be more similar, since the
> contrib moudules should get the same link option, instead of based on
> how many files need to be linked together, thus Makefile.aix should be
> changed to use SHLIB_LINK.
> 
> I am attaching all the patches for so for AIX to let it get 
> past Contrib
> on the buildfarm.
> 
> Makefile.aix.patch - will bring Makefile.aix in line with 
> Makefile.shlib
> by using SHLIB_LINK
> contrib.libs.patch - will pull in the needed libraries for contrib
> modules
> regress.pgport.patch - same idea as contrib patch, pull in the needed
> library
> 
> I hope this makes it a bit clearer what I am trying to 
> achieve by having
> all the pieces together in one place.
> 
> Thanks,
> 	-rocco
> 
> PS. I am starting to look at using the facilities in AIX to 
> support run
> time linked libraries instead of at compile time.  This does 
> require AIX
> 4.2+, so I will try to leave the 4.1 code in place.
> 
> ---------------------------(end of 
> broadcast)---------------------------
> TIP 1: if posting/reading through Usenet, please send an appropriate
>        subscribe-nomail command to majordomo(at)postgresql(dot)org 
> so that your
>        message can get through to the mailing list cleanly
> 

Attachment: regress.pgport.patch
Description: application/octet-stream (830 bytes)
Attachment: contrib.libs.patch
Description: application/octet-stream (3.7 KB)
Attachment: Makefile.aix.patch
Description: application/octet-stream (902 bytes)

Responses

pgsql-patches by date

Next:From: Alvaro HerreraDate: 2005-07-24 18:21:25
Subject: Re: [HACKERS] Autovacuum loose ends
Previous:From: Rocco AltierDate: 2005-07-24 17:15:05
Subject: Re: Regression - GNUmakefile - pg_usleep

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group