Skip site navigation (1) Skip section navigation (2)

Re: Couple of minor fixes

From: "Magnus Hagander" <mha(at)sollentuna(dot)net>
To: "Tom Lane" <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: <pgsql-patches(at)postgresql(dot)org>
Subject: Re: Couple of minor fixes
Date: 2006-04-09 19:27:21
Message-ID: 6BCB9D8A16AC4241919521715F4D8BCEA0F8F4@algol.sollentuna.se (view raw or flat)
Thread:
Lists: pgsql-patches
> > 2) timezone/localtime.c, transtime() has a const arcument in the 
> > implementation but non-const in declaration.
> 
> I did this the other way (make implementation match declaration).
> I think the coding was in fact correct per spec, because 
> const-ness of an argument value is not part of the function signature.

Ok.


> > I'm also seeing a lot of signed/unsigned mismatch, but IIRC it was 
> > said at some point that we don't care about those.
> 
> In HEAD?  They're all cleaned up according to the compilers I use.

Yup.
More digging then I guess. Probably a #define that's messe dup
somewhere.

//Magnus

Responses

pgsql-patches by date

Next:From: Tom LaneDate: 2006-04-09 19:48:56
Subject: Re: Couple of minor fixes
Previous:From: Tom LaneDate: 2006-04-09 19:24:41
Subject: Re: Couple of minor fixes

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group