locale issues on win32 (fix?)

From: "Magnus Hagander" <mha(at)sollentuna(dot)net>
To: <pgsql-hackers-win32(at)postgresql(dot)org>
Cc: <pgsql-hackers(at)postgresql(dot)org>
Subject: locale issues on win32 (fix?)
Date: 2004-04-19 21:11:28
Message-ID: 6BCB9D8A16AC4241919521715F4D8BCE34B7AE@algol.sollentuna.se
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers pgsql-hackers-win32

Hello!

Here is a temp fix for the locale issues on win32. It passes regression
tests, but is *NOT* ready to be applied (if nothing else, it at least
needs more error checking).

The issue is that locale settings were not inherited by the postgres
backends when they were execed... Instead, the locale was reset to
whatever the system default was. I have a few questions before I
continue fixing up the patch, though:

* Is it enough to explicitly store/save LC_COLLATE and LC_CTYPE, or does
more of the locale stuff need to be stored? I think the rest is handled
by GUC and should thus be reloaded by the GUC routines already, but I'm
not sure there.

* Does pgstat, startup, shutdown, checkpointer and bgwriter need to have
the locale set as well, or can they live with defaults? (my fix only
fixes standard backends, since they have different exec paths)

* Locale can't be changed "on-the-fly", if I'm correct. So just setting
it upon exec should be enough. Or am I wrong there?

//Magnus

Attachment Content-Type Size
locale_win32.patch application/octet-stream 1.1 KB

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Bruce Momjian 2004-04-19 21:20:33 Re: 'begin transaction' new syntax bug?
Previous Message Bruce Momjian 2004-04-19 21:09:23 Re: [HACKERS] Why is libpgtcl still in CVS?

Browse pgsql-hackers-win32 by date

  From Date Subject
Next Message Bruce Momjian 2004-04-19 22:32:39 Re: build annoyences
Previous Message Magnus Hagander 2004-04-19 19:41:15 Re: canceling query