Skip site navigation (1) Skip section navigation (2)

Re: canceling query

From: "Magnus Hagander" <mha(at)sollentuna(dot)net>
To: "Tom Lane" <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: "Merlin Moncure" <merlin(dot)moncure(at)rcsonline(dot)com>,<pgsql-hackers-win32(at)postgresql(dot)org>
Subject: Re: canceling query
Date: 2004-04-19 19:41:15
Message-ID: 6BCB9D8A16AC4241919521715F4D8BCE17164E@algol.sollentuna.se (view raw or flat)
Thread:
Lists: pgsql-hackers-win32
>> I beleive the fix needs to be in backend/utils/elog.c, function
>> useful_strerror(). Unless someone either tells me that's the 
>wrong place
>> or beats me to it, I'll try to get a patch done for this soonest.
>
>Sounds reasonable.  Better look also at errcode_for_socket_access() and
>other places that check for particular errno values.

The errno values are correct (they're #defined in win32.h), it's just
that the system supplied strerror() doesn't know about them.

>While you are at it you might want to make sure there aren't any other
>unprotected strerror() calls in the backend.  At one time we had a fair
>number of places with code like
>
>	elog("barf: %s", strerror(errno));
>
>and I'm not sure if all of them have gotten turned into %m or not.

From what I can see, there are a couple of places in postmaster.c that
uses it, and that's it. And it's all non-socket related. So I think
we're safe there.


Patch coming up shortly :-)

//Magnus

pgsql-hackers-win32 by date

Next:From: Magnus HaganderDate: 2004-04-19 21:11:28
Subject: locale issues on win32 (fix?)
Previous:From: Tom LaneDate: 2004-04-19 19:19:31
Subject: Re: canceling query

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group