From:
Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To:
Robert Haas <robertmhaas(at)gmail(dot)com>
Cc:
Alvaro Herrera <alvherre(at)commandprompt(dot)com>,
Teodor Sigaev <teodor(at)sigaev(dot)ru>,
Mark Cave-Ayland <mark(dot)cave-ayland(at)siriusit(dot)co(dot)uk>,
Pgsql Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject:
Re: [CFReview] Red-Black Tree
Date:
2010-02-09 03:43:08
Message-ID:
6895.1265686988@sss.pgh.pa.us (view raw or flat )
Thread:
2010-01-29 14:00:23 from Mark Cave-Ayland <mark(dot)cave-ayland(at)siriusit(dot)co(dot)uk>
2010-01-29 18:52:07 from Oleg Bartunov <oleg(at)sai(dot)msu(dot)su>
2010-01-29 19:04:01 from Robert Haas <robertmhaas(at)gmail(dot)com>
2010-01-29 19:14:08 from Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
2010-02-02 19:47:17 from Teodor Sigaev <teodor(at)sigaev(dot)ru>
2010-02-02 20:02:59 from Robert Haas <robertmhaas(at)gmail(dot)com>
2010-02-03 12:14:48 from Teodor Sigaev <teodor(at)sigaev(dot)ru>
2010-02-03 13:48:12 from Robert Haas <robertmhaas(at)gmail(dot)com>
2010-02-03 16:11:12 from Robert Haas <robertmhaas(at)gmail(dot)com>
2010-02-03 16:43:53 from Oleg Bartunov <oleg(at)sai(dot)msu(dot)su>
2010-02-03 16:47:15 from Robert Haas <robertmhaas(at)gmail(dot)com>
2010-02-03 21:17:00 from Oleg Bartunov <oleg(at)sai(dot)msu(dot)su>
2010-02-03 21:21:20 from Robert Haas <robertmhaas(at)gmail(dot)com>
2010-02-03 21:51:16 from Oleg Bartunov <oleg(at)sai(dot)msu(dot)su>
2010-02-04 02:27:33 from Robert Haas <robertmhaas(at)gmail(dot)com>
2010-02-04 13:19:20 from Mark Cave-Ayland <mark(dot)cave-ayland(at)siriusit(dot)co(dot)uk>
2010-02-04 15:30:17 from Oleg Bartunov <oleg(at)sai(dot)msu(dot)su>
2010-02-04 15:53:52 from Teodor Sigaev <teodor(at)sigaev(dot)ru>
2010-02-05 17:28:44 from Mark Cave-Ayland <mark(dot)cave-ayland(at)siriusit(dot)co(dot)uk>
2010-02-05 18:54:36 from Teodor Sigaev <teodor(at)sigaev(dot)ru>
2010-02-06 06:21:29 from Robert Haas <robertmhaas(at)gmail(dot)com>
2010-02-08 18:19:49 from Teodor Sigaev <teodor(at)sigaev(dot)ru>
2010-02-08 20:05:17 from Alvaro Herrera <alvherre(at)commandprompt(dot)com>
2010-02-09 03:35:54 from Robert Haas <robertmhaas(at)gmail(dot)com>
2010-02-09 03:43:08 from Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
2010-02-09 04:40:33 from Robert Haas <robertmhaas(at)gmail(dot)com>
2010-02-09 16:56:09 from Oleg Bartunov <oleg(at)sai(dot)msu(dot)su>
2010-02-09 14:02:11 from Alvaro Herrera <alvherre(at)commandprompt(dot)com>
2010-02-09 04:43:08 from Robert Haas <robertmhaas(at)gmail(dot)com>
2010-02-09 14:21:10 from Teodor Sigaev <teodor(at)sigaev(dot)ru>
2010-02-10 03:50:29 from Robert Haas <robertmhaas(at)gmail(dot)com>
2010-02-10 18:40:16 from Teodor Sigaev <teodor(at)sigaev(dot)ru>
2010-02-10 18:56:14 from Alvaro Herrera <alvherre(at)commandprompt(dot)com>
2010-02-10 19:32:26 from Teodor Sigaev <teodor(at)sigaev(dot)ru>
2010-02-10 18:56:21 from Robert Haas <robertmhaas(at)gmail(dot)com>
Lists:
pgsql-hackers
Robert Haas <robertmhaas(at)gmail(dot)com> writes:
> On Mon, Feb 8, 2010 at 3:05 PM, Alvaro Herrera
> <alvherre(at)commandprompt(dot)com> wrote:
>> It seems a bit strange to have all the rb_free_recursive support and not
>> use it anywhere ... and a freefunc callback even, whose only caller
>> seems to set as null currently. Hmm, even in the knngist patch the
>> rb_freefunc stuff is unused.
> I don't think it's inappropriate; it doesn't seem implausible that
> someone might want to free an rbtree someday. I suppose we could
> comment it out but I guess I don't see the point.
I think the suggestion was to *remove* it not comment it out. I'm
skeptical of carrying dead code. If the functionality is not used
in the proposed gist patches then it's very fair to question whether
it ever will be used.
regards, tom lane
In response to
Responses
pgsql-hackers by date
Next :From: Jaime CasanovaDate: 2010-02-09 04:01:53Subject : Re: set the cost of an aggregate functionPrevious :From : Andrew DunstanDate : 2010-02-09 03:38:39Subject : Re: CVS checkout source code for different branches
