Skip site navigation (1) Skip section navigation (2)

Re: [HACKERS] Patch for Prevent pg_dump/pg_restore from being affected by statement_timeout

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: daveg <daveg(at)sonic(dot)net>
Cc: Bruce Momjian <bruce(at)momjian(dot)us>, Alex Hunsaker <badalex(at)gmail(dot)com>, Alvaro Herrera <alvherre(at)commandprompt(dot)com>, Pg Patches <pgsql-patches(at)postgresql(dot)org>, "Joshua D(dot) Drake" <jd(at)commandprompt(dot)com>, Andrew Dunstan <andrew(at)dunslane(dot)net>, Greg Sabino Mullane <greg(at)turnstep(dot)com>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: [HACKERS] Patch for Prevent pg_dump/pg_restore from being affected by statement_timeout
Date: 2008-06-24 21:34:50
Message-ID: 6596.1214343290@sss.pgh.pa.us (view raw or flat)
Thread:
Lists: pgsql-hackerspgsql-patches
daveg <daveg(at)sonic(dot)net> writes:
> lock-timeout sets statement_timeout to a small value while locks are being
> taken on all the tables. Then it resets it to default. So it could reset it
> to whatever the new default is.

"reset to default" is *surely* not the right behavior; resetting to the
setting that had been in effect might be a bit sane.  But the whole
design sounds pretty broken to start with.  The timer management code
already understands the concept of scheduling the interrupt for the
nearest of a couple of potentially active timeouts.  ISTM any patch
intended to add a feature like this ought to extend that logic rather
than hack around changing the values of global variables.

			regards, tom lane

In response to

Responses

pgsql-hackers by date

Next:From: Zoltan BoszormenyiDate: 2008-06-24 21:36:39
Subject: Re: proposal for smaller indexes on index-ordered tables
Previous:From: Stephen R. van den BergDate: 2008-06-24 21:19:47
Subject: Re: Dept of ugly hacks: eliminating padding space in system indexes

pgsql-patches by date

Next:From: davegDate: 2008-06-25 00:01:03
Subject: Re: [HACKERS] Patch for Prevent pg_dump/pg_restore from being affected by statement_timeout
Previous:From: davegDate: 2008-06-24 20:53:58
Subject: Re: [HACKERS] Patch for Prevent pg_dump/pg_restore from being affected by statement_timeout

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group