From:
Robert Haas <robertmhaas(at)gmail(dot)com>
To:
Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc:
Euler Taveira de Oliveira <euler(at)timbira(dot)com>, Magnus Hagander <magnus(at)hagander(dot)net>, Fujii Masao <masao(dot)fujii(at)gmail(dot)com>, Marko Kreen <markokr(at)gmail(dot)com>, Tollef Fog Heen <tollef(dot)fog(dot)heen(at)collabora(dot)co(dot)uk>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject:
Re: TCP keepalive support for libpq
Date:
2010-02-15 16:18:40
Message-ID:
603c8f071002150818n32c617b0h126417514078689d@mail.gmail.com (view raw or flat )
Thread:
2010-02-09 13:03:28 from Tollef Fog Heen <tollef(dot)fog(dot)heen(at)collabora(dot)co(dot)uk>
2010-02-09 13:45:01 from Magnus Hagander <magnus(at)hagander(dot)net>
2010-02-09 13:57:24 from Tollef Fog Heen <tollef(dot)fog(dot)heen(at)collabora(dot)co(dot)uk>
2010-02-09 14:34:10 from Andrew Chernow <ac(at)esilo(dot)com>
2010-02-10 01:07:29 from Fujii Masao <masao(dot)fujii(at)gmail(dot)com>
2010-02-10 21:08:58 from daveg <daveg(at)sonic(dot)net>
2010-02-11 07:15:36 from Tollef Fog Heen <tollef(dot)fog(dot)heen(at)collabora(dot)co(dot)uk>
2010-02-11 16:16:36 from Robert Haas <robertmhaas(at)gmail(dot)com>
2010-02-11 16:27:43 from "Kevin Grittner" <Kevin(dot)Grittner(at)wicourts(dot)gov>
2010-02-11 16:33:35 from Peter Geoghegan <peter(dot)geoghegan86(at)gmail(dot)com>
2010-02-11 16:43:01 from Peter Geoghegan <peter(dot)geoghegan86(at)gmail(dot)com>
2010-02-12 02:52:27 from Fujii Masao <masao(dot)fujii(at)gmail(dot)com>
2010-02-12 09:40:26 from Peter Geoghegan <peter(dot)geoghegan86(at)gmail(dot)com>
2010-02-12 10:15:32 from Fujii Masao <masao(dot)fujii(at)gmail(dot)com>
2010-02-11 16:38:19 from Dimitri Fontaine <dfontaine(at)hi-media(dot)com>
2010-02-11 16:34:52 from Andrew Chernow <ac(at)esilo(dot)com>
2010-02-11 17:08:03 from Tollef Fog Heen <tollef(dot)fog(dot)heen(at)collabora(dot)co(dot)uk>
2010-02-12 15:50:30 from Marko Kreen <markokr(at)gmail(dot)com>
2010-02-12 17:13:06 from Euler Taveira de Oliveira <euler(at)timbira(dot)com>
2010-02-15 10:18:40 from Fujii Masao <masao(dot)fujii(at)gmail(dot)com>
2010-02-15 14:45:02 from Euler Taveira de Oliveira <euler(at)timbira(dot)com>
2010-02-15 14:52:13 from Magnus Hagander <magnus(at)hagander(dot)net>
2010-02-15 15:08:10 from Robert Haas <robertmhaas(at)gmail(dot)com>
2010-02-15 15:15:24 from Euler Taveira de Oliveira <euler(at)timbira(dot)com>
2010-02-15 16:00:45 from Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
2010-02-15 16:08:23 from Robert Haas <robertmhaas(at)gmail(dot)com>
2010-02-15 16:12:14 from Magnus Hagander <magnus(at)hagander(dot)net>
2010-02-15 16:15:20 from Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
2010-02-15 16:18:40 from Robert Haas <robertmhaas(at)gmail(dot)com>
2010-02-16 00:58:05 from Fujii Masao <masao(dot)fujii(at)gmail(dot)com>
2010-06-22 13:20:39 from Robert Haas <robertmhaas(at)gmail(dot)com>
2010-06-22 13:27:28 from Magnus Hagander <magnus(at)hagander(dot)net>
2010-06-22 16:16:49 from Robert Haas <robertmhaas(at)gmail(dot)com>
2010-06-22 16:32:08 from Magnus Hagander <magnus(at)hagander(dot)net>
2010-06-22 16:43:00 from Robert Haas <robertmhaas(at)gmail(dot)com>
2010-06-22 16:50:40 from Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
2010-06-22 17:08:53 from Robert Haas <robertmhaas(at)gmail(dot)com>
2010-06-22 17:14:55 from Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
2010-06-22 17:32:26 from Robert Haas <robertmhaas(at)gmail(dot)com>
2010-06-22 18:02:02 from Josh Berkus <josh(at)agliodbs(dot)com>
2010-06-22 18:20:31 from "Kevin Grittner" <Kevin(dot)Grittner(at)wicourts(dot)gov>
2010-06-22 18:24:23 from Josh Berkus <josh(at)agliodbs(dot)com>
2010-06-22 19:28:21 from Robert Haas <robertmhaas(at)gmail(dot)com>
2010-06-22 19:45:57 from Robert Haas <robertmhaas(at)gmail(dot)com>
2010-06-22 20:32:09 from Robert Haas <robertmhaas(at)gmail(dot)com>
2010-06-23 04:20:02 from Fujii Masao <masao(dot)fujii(at)gmail(dot)com>
2010-06-23 20:56:07 from Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
2010-06-23 21:22:35 from Robert Haas <robertmhaas(at)gmail(dot)com>
2010-06-22 17:04:43 from "Kevin Grittner" <Kevin(dot)Grittner(at)wicourts(dot)gov>
2010-06-24 11:54:16 from Greg Stark <gsstark(at)mit(dot)edu>
2010-06-24 14:40:59 from Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
2010-06-22 17:30:55 from Florian Pflug <fgp(at)phlo(dot)org>
2010-06-24 01:14:33 from Robert Haas <robertmhaas(at)gmail(dot)com>
2010-06-24 11:04:37 from Magnus Hagander <magnus(at)hagander(dot)net>
2010-02-11 09:18:46 from Magnus Hagander <magnus(at)hagander(dot)net>
2010-02-11 13:44:18 from Andrew Chernow <ac(at)esilo(dot)com>
2010-02-11 17:23:03 from Kris Jurka <books(at)ejurka(dot)com>
Lists:
pgsql-hackers
On Mon, Feb 15, 2010 at 11:15 AM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> Robert Haas <robertmhaas(at)gmail(dot)com> writes:
>> On Mon, Feb 15, 2010 at 11:00 AM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>>> If this were actually a low-risk patch I might think it was okay to try
>>> to shoehorn it in now; but IME nothing involving making new use of
>>> system-dependent APIs is ever low-risk. Look at Greg's current
>>> embarrassment over fsync, a syscall I'm sure he thought he knew all
>>> about.
>
>> That's why I think we shouldn't change the default behavior, but
>> exposing a new option that people can use or not as works for them
>> seems OK.
>
> That's assuming they get as far as having a working libpq to try it
> with. I'm worried about the possibility of inducing compile or link
> failures. "It works in the backend" doesn't give me that much confidence
> about it working in libpq.
>
> I'm all for this as a 9.1 submission, but let's not commit to trying to
> debug it now. I would like a green buildfarm for awhile before we wrap
> alpha4, and this sort of untested "it can't hurt" patch is exactly what
> is likely to make things not green.
Mmm. OK, fair enough.
...Robert
In response to
Responses
pgsql-hackers by date
Next :From: Tom LaneDate: 2010-02-15 16:21:04Subject : Re: Streaming Replication on win32 Previous :From : Tom LaneDate : 2010-02-15 16:15:20Subject : Re: TCP keepalive support for libpq
