From:
Robert Haas <robertmhaas(at)gmail(dot)com>
To:
KaiGai Kohei <kaigai(at)kaigai(dot)gr(dot)jp>
Cc:
KaiGai Kohei <kaigai(at)ak(dot)jp(dot)nec(dot)com>, Bernd Helmle <mailings(at)oopsware(dot)de>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, pgsql-hackers(at)postgresql(dot)org, Thom Brown <thombrown(at)gmail(dot)com>, Alvaro Herrera <alvherre(at)commandprompt(dot)com>
Subject:
Re: [BUG?] strange behavior in ALTER TABLE ... RENAME TO on inherited columns
Date:
2010-01-27 20:42:45
Message-ID:
603c8f071001271242k2e96c599k624adf87b36d4270@mail.gmail.com (view raw or flat )
Thread:
2009-11-04 06:36:15 from KaiGai Kohei <kaigai(at)ak(dot)jp(dot)nec(dot)com>
2009-11-04 13:31:36 from Alvaro Herrera <alvherre(at)commandprompt(dot)com>
2009-11-04 13:48:10 from Thom Brown <thombrown(at)gmail(dot)com>
2009-11-04 14:41:31 from Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
2009-11-05 00:57:03 from KaiGai Kohei <kaigai(at)ak(dot)jp(dot)nec(dot)com>
2009-12-17 04:30:00 from KaiGai Kohei <kaigai(at)ak(dot)jp(dot)nec(dot)com>
2009-12-30 01:38:40 from Robert Haas <robertmhaas(at)gmail(dot)com>
2010-01-02 15:16:35 from KaiGai Kohei <kaigai(at)kaigai(dot)gr(dot)jp>
2010-01-02 19:32:36 from Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
2010-01-03 14:53:41 from Robert Haas <robertmhaas(at)gmail(dot)com>
2010-01-03 17:31:10 from Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
2010-01-03 19:06:04 from Robert Haas <robertmhaas(at)gmail(dot)com>
2010-01-03 23:58:22 from KaiGai Kohei <kaigai(at)ak(dot)jp(dot)nec(dot)com>
2010-01-04 03:41:49 from Robert Haas <robertmhaas(at)gmail(dot)com>
2010-01-04 04:18:26 from Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
2010-01-04 04:52:09 from KaiGai Kohei <kaigai(at)ak(dot)jp(dot)nec(dot)com>
2010-01-04 09:55:16 from KaiGai Kohei <kaigai(at)ak(dot)jp(dot)nec(dot)com>
2010-01-14 03:43:27 from KaiGai Kohei <kaigai(at)ak(dot)jp(dot)nec(dot)com>
2010-01-14 07:04:17 from KaiGai Kohei <kaigai(at)ak(dot)jp(dot)nec(dot)com>
2010-01-23 18:45:11 from Bernd Helmle <mailings(at)oopsware(dot)de>
2010-01-24 03:29:23 from Robert Haas <robertmhaas(at)gmail(dot)com>
2010-01-24 03:48:35 from KaiGai Kohei <kaigai(at)kaigai(dot)gr(dot)jp>
2010-01-24 13:36:38 from Robert Haas <robertmhaas(at)gmail(dot)com>
2010-01-24 13:37:13 from Robert Haas <robertmhaas(at)gmail(dot)com>
2010-01-24 18:09:54 from Bernd Helmle <mailings(at)oopsware(dot)de>
2010-01-24 18:23:14 from Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
2010-01-24 18:45:33 from Bernd Helmle <mailings(at)oopsware(dot)de>
2010-01-24 19:01:10 from Bernd Helmle <mailings(at)oopsware(dot)de>
2010-01-24 19:30:30 from Robert Haas <robertmhaas(at)gmail(dot)com>
2010-01-24 23:45:38 from KaiGai Kohei <kaigai(at)ak(dot)jp(dot)nec(dot)com>
2010-01-25 02:39:21 from KaiGai Kohei <kaigai(at)ak(dot)jp(dot)nec(dot)com>
2010-01-25 05:08:35 from Robert Haas <robertmhaas(at)gmail(dot)com>
2010-01-25 05:29:12 from KaiGai Kohei <kaigai(at)ak(dot)jp(dot)nec(dot)com>
2010-01-25 15:58:14 from Robert Haas <robertmhaas(at)gmail(dot)com>
2010-01-25 16:11:22 from Bernd Helmle <mailings(at)oopsware(dot)de>
2010-01-26 01:10:58 from KaiGai Kohei <kaigai(at)ak(dot)jp(dot)nec(dot)com>
2010-01-27 08:50:19 from KaiGai Kohei <kaigai(at)ak(dot)jp(dot)nec(dot)com>
2010-01-27 14:29:06 from Robert Haas <robertmhaas(at)gmail(dot)com>
2010-01-27 15:17:45 from KaiGai Kohei <kaigai(at)kaigai(dot)gr(dot)jp>
2010-01-27 20:42:45 from Robert Haas <robertmhaas(at)gmail(dot)com>
2010-01-27 21:03:51 from Bernd Helmle <mailings(at)oopsware(dot)de>
2010-01-27 21:58:35 from Robert Haas <robertmhaas(at)gmail(dot)com>
2010-01-28 01:13:49 from KaiGai Kohei <kaigai(at)ak(dot)jp(dot)nec(dot)com>
2010-01-28 15:46:44 from Robert Haas <robertmhaas(at)gmail(dot)com>
2010-01-29 00:13:02 from KaiGai Kohei <kaigai(at)ak(dot)jp(dot)nec(dot)com>
2010-01-29 00:29:27 from Robert Haas <robertmhaas(at)gmail(dot)com>
2010-01-29 00:58:46 from KaiGai Kohei <kaigai(at)ak(dot)jp(dot)nec(dot)com>
2010-01-29 03:02:22 from KaiGai Kohei <kaigai(at)ak(dot)jp(dot)nec(dot)com>
2010-01-29 18:36:20 from Robert Haas <robertmhaas(at)gmail(dot)com>
2010-01-31 23:41:11 from KaiGai Kohei <kaigai(at)ak(dot)jp(dot)nec(dot)com>
2010-02-01 03:04:53 from KaiGai Kohei <kaigai(at)ak(dot)jp(dot)nec(dot)com>
2010-02-01 18:01:21 from Robert Haas <robertmhaas(at)gmail(dot)com>
2010-02-01 18:31:10 from Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
2010-02-01 18:40:06 from Robert Haas <robertmhaas(at)gmail(dot)com>
2010-02-01 18:55:56 from Robert Haas <robertmhaas(at)gmail(dot)com>
2010-02-01 19:03:38 from Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
2010-02-01 19:29:17 from Robert Haas <robertmhaas(at)gmail(dot)com>
2010-02-02 00:48:42 from KaiGai Kohei <kaigai(at)ak(dot)jp(dot)nec(dot)com>
2010-02-02 01:47:17 from KaiGai Kohei <kaigai(at)ak(dot)jp(dot)nec(dot)com>
2010-02-02 02:09:51 from Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
2010-02-02 02:20:26 from KaiGai Kohei <kaigai(at)ak(dot)jp(dot)nec(dot)com>
2010-02-02 02:31:01 from Robert Haas <robertmhaas(at)gmail(dot)com>
2010-02-02 02:39:07 from KaiGai Kohei <kaigai(at)ak(dot)jp(dot)nec(dot)com>
2010-02-02 02:44:20 from Robert Haas <robertmhaas(at)gmail(dot)com>
2010-02-02 02:55:17 from KaiGai Kohei <kaigai(at)ak(dot)jp(dot)nec(dot)com>
2010-02-02 14:50:53 from Robert Haas <robertmhaas(at)gmail(dot)com>
2010-02-02 23:40:45 from KaiGai Kohei <kaigai(at)ak(dot)jp(dot)nec(dot)com>
2010-02-02 02:32:01 from Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
2010-01-28 00:37:19 from KaiGai Kohei <kaigai(at)ak(dot)jp(dot)nec(dot)com>
2010-01-24 12:13:44 from Bernd Helmle <mailings(at)oopsware(dot)de>
2010-01-04 18:19:55 from Robert Haas <robertmhaas(at)gmail(dot)com>
Lists:
pgsql-hackers
On Wed, Jan 27, 2010 at 10:17 AM, KaiGai Kohei <kaigai(at)kaigai(dot)gr(dot)jp> wrote:
> (2010/01/27 23:29), Robert Haas wrote:
>>
>> 2010/1/27 KaiGai Kohei<kaigai(at)ak(dot)jp(dot)nec(dot)com>:
>>>
>>> The attached patch is revised one based on the V3 approach.
>>> The only difference from V3 is that it also applies checks on the
>>> AT_AlterColumnType option, not only renameatt().
>>
>> I think I was clear about what the next step was for this patch in my
>> previous email, but let me try again.
>>
>> http://archives.postgresql.org/pgsql-hackers/2010-01/msg02407.php
>>
>> See also Tom's comments here:
>>
>> http://archives.postgresql.org/pgsql-hackers/2010-01/msg00110.php
>>
>> I don't believe that either Tom or I are prepared to commit a patch
>> based on this approach, at least not unless someone makes an attempt
>> to do it the other way and finds an even more serious problem. If
>> you're not interested in rewriting the patch along the lines Tom
>> suggested, then we should just mark this as Returned with Feedback and
>> move on.
>
> The V3/V5 patch was the rewritten one based on the Tom's comment, as is.
> It counts the expected inhcount at the first find_all_inheritors() time
> at once, and it compares the pg_attribute.attinhcount.
> (In actually, find_all_inheritors() does not have a capability to count
> the number of merged from a common origin, so I newly defined the
> find_all_inheritors_with_inhcount().)
>
> Am I missing something?
Err... I'm not sure. I thought I understood what the different
versions of this patch were doing, but apparently I'm all confused.
I'll take another look at this.
Bernd (or anyone), feel free to take a look in parallel. More eyes
would be helpful...
...Robert
In response to
Responses
pgsql-hackers by date
Next :From: Bernd HelmleDate: 2010-01-27 21:03:51Subject : Re: [BUG?] strange behavior in ALTER TABLE ... RENAME TO
on inherited columnsPrevious :From : Robert HaasDate : 2010-01-27 20:37:37Subject : Re: xpath improvement suggestion
