Skip site navigation (1) Skip section navigation (2)

Re: CF 2009-09: initial reviewing assignments

From: Robert Haas <robertmhaas(at)gmail(dot)com>
To: Abhijit Menon-Sen <ams(at)toroid(dot)org>
Cc: pgsql-rrreviewers(at)postgresql(dot)org
Subject: Re: CF 2009-09: initial reviewing assignments
Date: 2009-09-16 16:44:34
Message-ID: 603c8f070909160944g7bac4e78w6c03777baa978233@mail.gmail.com (view raw or flat)
Thread:
Lists: pgsql-rrreviewers
On Wed, Sep 16, 2009 at 12:44 PM, Robert Haas <robertmhaas(at)gmail(dot)com> wrote:
> On Wed, Sep 16, 2009 at 1:38 AM, Abhijit Menon-Sen <ams(at)toroid(dot)org> wrote:
>> At 2009-09-14 21:08:56 -0400, robertmhaas(at)gmail(dot)com wrote:
>>>
>>> Logging configuration changes
>>> - Abhijit Menon-Sen <ams(at)toroid(dot)org>
>>
>> I reviewed this patch. It's fine. Ready for committer as-is.
>>
>> But I suggested some minor changes that I thought were useful, and
>> posted a new version of the patch including those changes. Besides
>> that, I posted a patch to implement a suggestion Peter made in his
>> original posting.
>>
>> What status should I assign the patch now? It's "Needs Review", in
>> a sense, but also "Waiting on Author", "Ready for Committer", and
>> "Returned with Feedback" ;-)
>>
>> The patch is completely trivial, before and after, so I feel a bit silly
>> even to ask this question. Should I just advance it to "Ready"?
>
> Yep, Ready for Committer sounds good to me.

Oh, and make sure to add a comment of type "Patch" with a link to your
version of the patch.

...Robert

In response to

pgsql-rrreviewers by date

Next:From: Nikhil SontakkeDate: 2009-09-17 06:25:25
Subject: Re: CF 2009-09: initial reviewing assignments
Previous:From: Robert HaasDate: 2009-09-16 16:44:06
Subject: Re: CF 2009-09: initial reviewing assignments

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group