On Tue, Jul 21, 2009 at 7:47 PM, Tom Lane<tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> Robert Haas <robertmhaas(at)gmail(dot)com> writes:
>> Here is an updated version of my "generic options for explain" patch.
>
> What is the rationale for essentially duplicating defGetBoolean()?

I just didn't realize we already had something along those lines.
Updated patch attached, to which I've also applied Andres Freund's
parser changes, suggested here:

http://archives.postgresql.org/pgsql-hackers/2009-07/msg01213.php

> Also, I'd suggest changing the ExplainStmt struct to have a list of
> DefElem options instead of hard-wiring the option set at that level.

What is the advantage of that?

...Robert

In response to

• Re: generic explain options v3 at 2009-07-21 23:47:51 from Tom Lane

Responses

• Re: generic explain options v3 at 2009-07-22 02:05:30 from Tom Lane

pgsql-hackers by date

Next:	From: Tom Lane	Date: 2009-07-22 01:23:28
	Subject: Re: Modifying TOAST_TUPLE_THRESHOLD and TOAST_TUPLE_TARGET?
Previous:	From: Tom Lane	Date: 2009-07-22 01:21:22
	Subject: pgsql: Tweak TOAST code so that columns marked with MAIN storage