Re: PATCH: Exclude additional directories in pg_basebackup

From: David Steele <david(at)pgmasters(dot)net>
To: Michael Paquier <michael(dot)paquier(at)gmail(dot)com>
Cc: Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org>, Ashutosh Sharma <ashu(dot)coek88(at)gmail(dot)com>
Subject: Re: PATCH: Exclude additional directories in pg_basebackup
Date: 2016-09-09 13:18:29
Message-ID: 52daf4a4-3b79-739c-15bf-9f8182a8be4e@pgmasters.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 9/6/16 10:25 PM, Michael Paquier wrote:
>
> On Wed, Sep 7, 2016 at 12:16 AM, David Steele <david(at)pgmasters(dot)net> wrote:
>
>> Attached is a new patch that adds sgml documentation. I can expand on each
>> directory individually if you think that's necessary, but thought it was
>> better to lump them into a few categories.
>
> + be ommitted from the backup as they will be initialized on postmaster
> + startup. If the <xref linkend="GUC-STATS-TEMP-DIRECTORY"> is set and is
> + under the database cluster directory then the contents of the directory
> + specified by <xref linkend="GUC-STATS-TEMP-DIRECTORY"> can also
> be ommitted.
>
> s/ommitted/omitted/

Fixed.

> +#define EXCLUDE_DIR_MAX 8
> +#define EXCLUDE_DIR_STAT_TMP 0
> +
> +const char *excludeDirContents[EXCLUDE_DIR_MAX] =
> +{
> + /*
> + * Skip temporary statistics files. The first array position will be
> + * filled with the value of pgstat_stat_directory relative to PGDATA.
> + * PG_STAT_TMP_DIR must be skipped even when stats_temp_directory is set
> + * because PGSS_TEXT_FILE is always created there.
> + */
> + NULL,
> I find that ugly. I'd rather use an array with undefined size for the
> fixed elements finishing by NULL, remove EXCLUDE_DIR_MAX and
> EXCLUDE_DIR_STAT_TMP and use a small routine to do the work done on
> _tarWriteHeader...

Done. Also writing out pg_xlog with the new routine.

--
-David
david(at)pgmasters(dot)net

Attachment Content-Type Size
basebackup-exclusions-v3.patch text/plain 9.9 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2016-09-09 13:21:57 Re: [sqlsmith] Failed assertion in joinrels.c
Previous Message Heikki Linnakangas 2016-09-09 13:14:34 More ideas for speeding up sorting