Skip site navigation (1) Skip section navigation (2)

Re: "serializable" in comments and names

From: Robert Haas <robertmhaas(at)gmail(dot)com>
To: Kevin Grittner <Kevin(dot)Grittner(at)wicourts(dot)gov>
Cc: "<pgsql-hackers(at)postgresql(dot)org>" <pgsql-hackers(at)postgresql(dot)org>, Dan Ports <drkp(at)csail(dot)mit(dot)edu>
Subject: Re: "serializable" in comments and names
Date: 2010-09-01 23:26:52
Message-ID: 51462CBE-7575-46CC-B4DD-412577ED1E1F@gmail.com (view raw or flat)
Thread:
Lists: pgsql-hackers
On Sep 1, 2010, at 11:02 AM, "Kevin Grittner" <Kevin(dot)Grittner(at)wicourts(dot)gov> wrote:
> The patch to implement true serializable transactions using SSI
> renames/rewords these things to avoid confusion.  However, there are
> seven files which are changed only for this reason, and another
> where there is one "real" change of two lines hidden in the midst of
> dozens of lines of such wording changes.  I find it distracting to
> have all this mixed in, and I fear that it will be a time-waster for
> anyone reviewing the meat of the patch.  I'd like to submit a
> "no-op" patch to cover these issues in advance of the CF, to get
> them out of the way.  Joe suggested that I pose the issue to the
> -hackers list.

+1.

> I could knock out a couple other files from the main patch if people
> considered it acceptable to enable the SHMQueueIsDetached function
> now, which the patch uses in several places within asserts.  I would
> remove the #ifdef NOT_USED from around the (very short) function,
> and add it to the .h file.

-1.

> The changes to the comments and local variables seem pretty safe. 
> The change of IsXactIsoLevelSerializable to
> IsXactIsoLevelXactSnapshotBased (or whatever name the community
> prefers)

How about IsXactIsoLevelSnapshot?  Just to be a bit shorter.

...Robert

In response to

Responses

pgsql-hackers by date

Next:From: Tom LaneDate: 2010-09-01 23:55:45
Subject: Re: compiling with RELCACHE_FORCE_RELEASE doesn't pass regression
Previous:From: Robert HaasDate: 2010-09-01 23:20:12
Subject: Re: Path question

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group